[AMQ-3012] HttpTunnelServlet incorrectly swallows exceptions during transport creation.

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.4.1
• Fix Version/s: 5.6.0
• Component/s: Transport
• Patch Info: Patch Available
• Assignee: Unassigned
• Reporter: Stirling Chow
• Created: 02/Nov/10 20:53
• Updated: 20/Sep/11 10:42
• Resolved: 06/Jul/11 23:07

Description

Symptom
=======
org.apache.activemq.transport.http.HttpTunnelServlet.java contains the following logic:

protected BlockingQueueTransport createTransportChannel(HttpServletRequest request, HttpServletResponse response) throws IOException {
...
clients.put(clientID, answer);
Transport transport = answer;
try

{ HashMap options = new HashMap(transportOptions); transport = transportFactory.serverConfigure(answer, null, options); }

catch (Exception e)

{ IOExceptionSupport.create(e); }

If the call to transportFactory.serverConfigure(...) throws an exception, IOExceptionSupport.create(e) is called, which wraps the exception in an IOException, but that IOException is never thrown.

Solution
=======
See attached patch file. Add a "throw" clause to propagate the IOException.