[AMQ-2430] embedded RESTful fileserver do not close files when PUT method is called

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.2.0, 5.3.0
• Fix Version/s: 5.6.0
• Component/s: Broker

Environment

linux 64 bits, but probably not significant

• Patch Info: Patch Available
• Assignee: Unassigned
• Reporter: Fabien MARTY
• Created: 28/Sep/09 20:37
• Updated: 20/Sep/11 10:41
• Resolved: 10/Aug/11 22:32

Description

When doing a massive uploading of blobs with activemq 5.2 (same thing on svn trunk) on the embedded RESTful fileserver, you get a "too many open files" error and the system doesn't work anymore.

Steps to reproduce :

• send a BlobMessage with "jms.blobTransferPolicy.uploadUrl=http://127.0.0.1:8161/fileserver/"
• use "lsof |grep fileserver" command and you will see your uploaded BLOB still open

The fix seems really easy (works ok for me) :

• open "RestFilter.java"
• locate the "doPut()" method
• change :

   
  try {
      IO.copy(request.getInputStream(), out);
   } catch (IOException e) {
  

with :

 
try {
    IO.copy(request.getInputStream(), out);
    out.close();
 } catch (IOException e) {