[AMQ-2191] Incorrect handling of interruptions during commit or rollback of a transaction

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.3.0
• Fix Version/s: 5.13.0

Environment

Java 1.6.0_02
Kubuntu Linux 2.6.24-22
Bitronix Transaction Manager 1.3.2

• Patch Info: Patch Available
• Assignee: Gary Tully
• Reporter: Michael Gottschalk
• Created: 01/Apr/09 14:18
• Updated: 31/Jul/18 13:48
• Resolved: 27/Nov/15 12:55

Description

We have a process framework that sends interruptions to threads that should be stopped or paused. Some of these threads interact with ActiveMQ, so interruptions can occur inside ActiveMQ at different points.
A problem occurs if the interruption is detected in ActiveMQConnection.syncSendPacket during commit or rollback of a transaction. ActiveMQ then throws a JMSException so that it appears to Bitronix as if the XA transaction is in an inconsistent state (see stacktrace in the attached file).

In our opinion, the interruption should be ignored by ActiveMQ during the critical commit or rollback phase. It is not mandatory that an interruption has an immediate effect. Especially such a non-interruptable step as rollback or commit should be performed even though an interruption occurs.

I created a patch for the class TransactionContext which, in case of an interruption, resets the interruption state of the thread, retries the syncSendPacket method call and restores the thread's interruption state afterwards. In this manner, no inconsistent state exceptions occur in the transaction manager any longer and interruption is deferred until the commit/rollback has succeeded.

Issue Links

• is related to: AMQ-3547 Calling Connection.close() on interrupted thread generates InterruptedIOException and leaks Connection