[AMQ-2079] conflict between checking validity of createSession args and requirement to ignore them in managed environment

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.3.0
• Fix Version/s: 5.3.0
• Component/s: Connector
• Assignee: David Jencks
• Reporter: David Jencks
• Created: 20/Jan/09 02:12
• Updated: 20/Jan/15 17:51
• Resolved: 20/Jan/09 02:13

Description

Since amq 4 someone added some parameter checking to ActiveMQConnection.createSession. This seems like a good idea until you get to the connector and read the ejb spec where it says in a managed environment these parameters should be ignored. I'm not sure how much they really can be ignored if an xa tx is not present. What I've done is to enhance the checking in ActiveMQConnection.createSession to be more thorough with better messages and to modify the ra ManagedConnectionProxy to modify one of the parameters if they are inconsistent (i.e. transacted == false, but ack mode == SESSION_TRANSACTED) (I change it to AUTO_ACKNOWLDEDGE). I haven't found this causing any problems.

Issue Links

• is related to: AMQ-5264 Allow optional manual transaction management on a rar managedConnection