[AMQ-1689] (NIO)DataFileAppender does to many sync or force calls when there is little or no concurrency

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.1.0
• Fix Version/s: 5.1.0
• Component/s: Message Store

Environment

Windows, NIO force and File sync perform poorly

• Patch Info: Patch Available
• Assignee: Hiram R. Chirino
• Reporter: Gary Tully
• Created: 25/Apr/08 13:13
• Updated: 01/May/08 09:18
• Resolved: 29/Apr/08 21:01

Description

Where NIO channel force and fileDescriptor.sync perform poorly and there is little concurrently, the kaha DataFileAppender performs poorly.
A test case where a single producer and consumer operate from either ends of a networked pair of brokers shows the problem. It takes ~3 minutes to send 1000 messages on windows!. The problem is that 70% of the time is spent in NIO channel.flush()

The flush is batched if there are concurrent writes, but otherwise, a single write is flushed immediately.
My proposal is to have the batch processor batch till a batch is full or till a sync flag is present in a write command or till some timeout expires or if the appender is closed.
This reduces the number of force calls and with this change, my test case can do 1000 messages in ~1minute.