[AMQ-1309] [DefaultDatabaseLocker] Do not log full stack trace when lock cannot be obtained

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 4.1.0
• Fix Version/s: AGING_TO_DIE
• Component/s: Message Store
• Assignee: Unassigned
• Reporter: Kenny MacLeod
• Created: 04/Jul/07 11:39
• Updated: 09/Jul/11 20:57
• Resolved: 09/Jul/11 20:57

Description

In DefaultDatabaseLocker.start(), the locking mechanism uses a continuous retry to obtain the lock. When a given try fails (e.g. because of a lock timeout), then the full exception stack trace is logged. For long-running slave brokers, this results is large, noisy log files full of stack traces, for a condition which is in fact non-exceptional.

I suggest that this logging is reduced to log just the exception message:

log.error("Failed to acquire lock: " + e.getMessage();

Better yet, use Spring's SQLErrorCodeSQLExceptionTranslator to translate the "cannot acquire lock" SQLException into a CannotAcquireLockException, and catch that explicitly in DefaultDatabaseLocker. Then you can just log a message saying "couldn't acquire lock, retrying". Any other exception type can log the full stack trace as before.