[AMQ-1089] Warning when using multicast discoveryUri

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.0.1, 4.0.2
• Fix Version/s: 4.1.1, 5.0.0

Environment

reproduced on Windows XP Pro and SuSE Linux Enterprise 9.1

• Patch Info: Patch Available
• Assignee: Unassigned
• Reporter: Olaf Brandt
• Created: 05/Dec/06 15:04
• Updated: 26/Feb/07 18:23
• Resolved: 06/Dec/06 10:28

Description

When using a transportconnector with a multicast discoveryagent a warning is shown.

config: <transportConnector name="default" uri="tcp://localhost:61616" discoveryUri="multicast://default"/>

WARN MulticastDiscoveryAgent -brokerName not set

When the transportconnector is started the MulticastDiscoveryAgent is created if it does not exist,
but the brokerName for this MulticastDiscoveryAgent is not set by the transportconnector.

See the code and the suggested modification to prevent this warning:

org.apache.activemq.broker.TransportConnector.java

<snip>
public void start() throws Exception {
getServer().start();
DiscoveryAgent da = getDiscoveryAgent();
if( da!=null ) {
da.registerService(getConnectUri().toString());
//suggested modification start
if(da.getBrokerName() == null || da.getBrokerName().length == 0)

{ da.setBrokerName(this.getBroker().getBrokerName()); }

//suggested modification end
da.start();
}
this.statusDector.start();
log.info("Connector "getName()" Started");
}
<snap>