[AMBARI-9805] RU - Bug fixes for Host Version transition and Finalize

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Component/s: ambari-server
• Labels: rolling_upgrade
• Assignee: Alejandro Fernandez
• Reporter: Alejandro Fernandez
• Created: 26/Feb/15 02:09
• Updated: 02/Mar/15 19:07
• Resolved: 28/Feb/15 18:11

Description

1. There is a bug in ServiceComponentHostSummary.java since its constructor should not be comparing against the string UKNOWN, but rather rely on ComponentInfo to determine which components need to advertise a version. Also, the function haveAllComponentsFinishedAdvertisingVersion should instead compare the size of all components that can advertise a version, and the subset of those that have done so already.

2. ClusterImpl.java has a bug in transitionHostVersionState() when setting the state to UPGRADING if the Host has exactly one Component with a version.

3. FinalizeUpgradeAction.java has redundant code now that AMBARI-9755 is in because the call to transitionClusterVersion() will also take care of transitioning HostVersions from INSTALLED->CURRENT for hosts that only have components that do not advertise a version.

It is of the utmost importance to test these changes in the following scenarios:
Host added during cluster install
Host added after cluster install
Host added after bits are distributed

A Host may be added with either 0 services, only services that do not advertise a version, or at least one service that advertises a version.

Issue Links

• links to: Code Review patch