[AMBARI-24296] [Yarn Queue Manager] Yarn Queue manager is allowing to Create a Child Queue for queue-mappings enabled Queue and Save it

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.7.0
• Fix Version/s: trunk, 2.7.3
• Component/s: ambari-views
• Labels: pull-request-available
• Assignee: Akhil Naik
• Reporter: Akhil Naik
• Created: 17/Jul/18 12:00
• Updated: 03/Oct/19 08:05
• Resolved: 03/Oct/19 08:05

Description

Yarn Queue manager is allowing to Create a Child Queue for queue-mappings enabled Queue and Save the changes
But the Operating is Failing as Yarn is having a check that Queue-mappings should only be allowed for Leaf queue

Code which validates whether queue-mappings are enabled only for leaf-queue ( YARN CODE)

private static QueueMapping validateAndGetQueueMapping(
      CapacitySchedulerQueueManager queueManager, CSQueue queue,
      QueueMapping mapping, QueuePath queuePath) throws IOException {
    if (!(queue instanceof LeafQueue)) {
      throw new IOException(
          "mapping contains invalid or non-leaf queue : " + mapping.getQueue());
    }

The buggy code in [Ambari Yarn Queue Manager which needs rework]:

https://github.com/apache/ambari/blob/79cca1c7184f1661236971dac70d85a83fab6c11/contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queues.js#L410

 hasInvalidMapping = queues.filter(function(queue){
            return !queue.get("queues"); //get all leaf queues
          }).map(function(queue){
            return queue.get("name");
          }).indexOf(mapping[2]) == -1;

Issue Links

• links to: GitHub Pull Request #1776
• links to: GitHub Pull Request #1940