[AMBARI-23334] Provider URL validator incorrect when setting up SSO via Ambari CLI

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.7.0
• Fix Version/s: 2.7.0
• Component/s: ambari-server
• Labels: pull-request-available
• Assignee: Sandor Molnar
• Reporter: Sandor Molnar
• Created: 23/Mar/18 08:13
• Updated: 28/Mar/18 20:00
• Resolved: 28/Mar/18 20:00

Description

When setting the URL for the SSO provider while running ambari-server setup-sso, valid URLs are rejected.

[root@c7402 ~]# ambari-server setup-sso
Using python  /usr/bin/python
Setting up SSO authentication properties...
Do you want to configure SSO authentication [y/n] (y)?y
Provider URL [URL] (http://example.com):https://c7402.ambari.apache.org:8443/gateway/knoxsso/api/v1/websso
Invalid provider URL
Provider URL [URL] (http://example.com):c7402.ambari.apache.org:8443
Public Certificate pem (empty) (empty line to finish input):

Cause:
The RegEx validating the URL is only allowing hostname and port values, when it should allow for absolute URLs.

ambari_server/setupSso.py:72

provider_url = get_validated_string_input("Provider URL [URL] ({0}):".format(provider_url), provider_url, REGEX_HOSTNAME_PORT,
                                                "Invalid provider URL", False)

Issue Links

• links to: GitHub Pull Request #760