[AMBARI-21442] Ambari updates memory settings in blueprint incorrectly

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.2
• Fix Version/s: 3.0.0
• Component/s: ambari-server
• Assignee: Attila Magyar
• Reporter: Attila Magyar
• Created: 11/Jul/17 13:26
• Updated: 17/Jul/17 09:00
• Resolved: 17/Jul/17 08:24

Description

Ambari appended a 'm' suffix to certain memory settings related properties during blueprint install. This was implemented in the MPropertyUpdater.

For example if namenode_heapsize was 512 then Ambari updated it to 512m. However if the property already had a suffix like 4g then it was updated to be 4gm.

This patch does 2 things differently
1. Instead of the hardcoded 'm' suffix, it uses the unit that is defined in the stack (if the stack doesn't define anything it falls back using 'm' as before).
2. It checks if the property already has some unit, and if that unit doesn't match the stack defined unit, then the blueprint will be rejected with an error (this case has never worked before)

For examples:
1. 4g is rejected if the stack defined unit is MB.
2. 4 becomes 4m if the stack defined unit is MB.
3. 4m stays 4m if the stack defined unit is MB.

MPropertyUpdated was replaced with UnitUpdater. But a new TopologyValidator was also introduced. The purpose of this is to catch invalid properties earlier.

Issue Links

• links to: review board