[AMBARI-21182] Agent Host Disk Usage Alert Hardcodes the Stack Directory

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.5.2
• Assignee: Andrew Onischuk
• Reporter: Andrew Onischuk
• Created: 06/Jun/17 10:45
• Updated: 08/Jun/17 12:55
• Resolved: 06/Jun/17 10:58

Description

The Host Disk Usage alert currently hard codes the stack location directly
into the script:

1. the location where HDP installs components when using HDP 2.2+
   STACK_HOME_DIR = "/usr/hdp"
2. the location where HDP installs components when using HDP 2.0 to 2.1
   STACK_HOME_LEGACY_DIR = "/usr/lib"
3. determine the location of HDP home
   stack_home = None
   if os.path.isdir(STACK_HOME_DIR):
   stack_home = STACK_HOME_DIR
   elif os.path.isdir(STACK_HOME_LEGACY_DIR):
   stack_home = STACK_HOME_LEGACY_DIR

On clusters where a different stack is installed (such as `/usr/hdf`, the
above logic incorrectly checks the `STACK_HOME_LEGACY_DIR`.

• The 2.0 and 2.1 code paths should be removed since they are not supported anymore.
• We should parameterize STACK_HOME_DIR (or even better, use the stack features JSON structure) to determine the home location to check.

Issue Links

• links to: ReviewBoard