Uploaded image for project: 'Ambari'
  1. Ambari
  2. AMBARI-20823

Remove user input from invalid renderer error message

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Critical
    • Resolution: Fixed
    • 1.5.0
    • 2.5.1
    • ambari-server
    • None

    Description

      Remove user input from invalid renderer error message to avoid potential XSS attacks.

      The user input data returned in the exception thrown at

      org/apache/ambari/server/api/resources/BaseResourceDefinition.java:135
            throw new IllegalArgumentException("Invalid renderer name: " + name +
                " for resource of type: " + m_type);
      

      should be removed and the error message changed to:

      Invalid renderer name for resource of type <resource type>.m
      

      or simply

      Invalid renderer name.
      

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            amagyar Attila Magyar
            rlevas Robert Levas
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment