[AMBARI-20672] Cluster Merge At End Of Upgrade Creation Cascades Unnecessarily

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.4.2
• Fix Version/s: 2.5.1
• Component/s: ambari-server
• Assignee: Jonathan Hurley
• Reporter: Jonathan Hurley
• Created: 04/Apr/17 16:57
• Updated: 16/Feb/18 13:13
• Resolved: 04/Apr/17 21:09

Description

During the creation of an upgrade, an association is made between the ClusterEntity and the UpgradeEntity so that determining if an upgrade is in progress can be fast.

    upgradeEntity.setRequestId(request.getId());

    request.persist();

    s_upgradeDAO.create(upgradeEntity);
    cluster.setUpgradeEntity(upgradeEntity);

  public void setUpgradeEntity(UpgradeEntity upgradeEntity) throws AmbariException {
    try {
      ClusterEntity clusterEntity = getClusterEntity();
      clusterEntity.setUpgradeEntity(upgradeEntity);
      clusterDAO.merge(clusterEntity);
...

The problem here is that the merge is propagated to the UpgradeEntity via a CascadeType.ALL and it's not necessary. It seems like the only cascade should be CascadeType.REMOVE

Issue Links

• links to: Reviewboard