[AMBARI-20049] One way SSL fallback logic can cause some agents to be connected with 2-way SSL

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.5.0
• Assignee: Andrew Onischuk
• Reporter: Andrew Onischuk
• Created: 16/Feb/17 13:48
• Updated: 16/Feb/17 16:26
• Resolved: 16/Feb/17 15:36

Description

We have fallback logic since a long time in the agent to try to connect to the
server with 2-way SSL if one-way SSL throws an exception. This can cause some
agents to connect with 2-way SSL (connection timeout exception for one-way
SSL) and thereby a cluster having a mix of agents, some connected with one-way
SSL and some connected with 2-way SSL.

Investigate why we have had this logic and if it is no longer appropriate,
remove this fallback logic.

<https://github.com/apache/ambari/blob/trunk/ambari-
agent/src/main/python/ambari_agent/security.py#L57-L67>

if not self.two_way_ssl_required:
try:
sock = self.create_connection()
self.sock = ssl.wrap_socket(sock, cert_reqs=ssl.CERT_NONE)
logger.info('SSL connection established. Two-way SSL authentication is '
'turned off on the server.')
except (ssl.SSLError, AttributeError):
self.two_way_ssl_required = True
logger.info(
'Insecure connection to https://' + self.host + ':' + self.port +
'/ failed. Reconnecting using two-way SSL authentication..')

Issue Links

• links to: ReviewBoard