[AMBARI-17962] Coverity Scan Security Vulnerability - SQL injection

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.2.0
• Fix Version/s: 2.4.0
• Component/s: ambari-server
• Labels: coverity security
• Assignee: Robert Levas
• Reporter: Robert Levas
• Created: 29/Jul/16 17:13
• Updated: 01/Aug/16 20:19
• Resolved: 01/Aug/16 18:19

Description

The Ambari coverity scan found two "High impact security" issues, both SQL Injections. They are both the same coding issue, but one is in OracleConnector.java, and one is in the analogous method in PostgresConnector.java.

This is the key description:

CID 167755 (#1 of 1): SQL injection (SQLI)9. sql_taint: Insecure concatenation of a SQL statement. The value searchClause is tainted.

Perform one of the following to guard against SQL injection attacks.

• Parameterize the SQL statement using ? positional characters. Bind the tainted values to the ? positional parameters using one of the PreparedStatement.set* methods.
• Validate user-supplied values against predefined constant values. Concatenate these constant values into the SQL statement.
• Cast tainted values to safe types such as integers. Concatenate these type safe values into the statement.

More Information

This is the one in OracleConnector.java, lines 32 -55:

32  @Override
  8. taint_path_param: Parameter searchClause receives the tainted data.
33  protected PreparedStatement getQualifiedPS(Statements statement, String searchClause, Workflows.WorkflowDBEntry.WorkflowFields field, boolean sortAscending, int offset, int limit) throws IOException {
34    if (db == null)
35      throw new IOException("db not initialized");
36
37    String order = " ORDER BY " + field.toString() + " " + (sortAscending ? SORT_ASC : SORT_DESC);
38
39    String query = "select * \n" +
40        "  from ( select " +
41//        "/*+ FIRST_ROWS(n) */ \n" +
42        "  a.*, ROWNUM rnum \n" +
43        "      from ("
  CID 167755 (#1 of 1): SQL injection (SQLI)9. sql_taint: Insecure concatenation of a SQL statement. The value searchClause is tainted.
  Perform one of the following to guard against SQL injection attacks.

    Parameterize the SQL statement using ? positional characters. Bind the tainted values to the ? positional parameters using one of the PreparedStatement.set* methods.
    Validate user-supplied values against predefined constant values. Concatenate these constant values into the SQL statement.
    Cast tainted values to safe types such as integers. Concatenate these type safe values into the statement.

More Information
44        + statement.getStatementString() + searchClause + order +
45        ") a \n" +
46        "      where ROWNUM <= " + (offset + limit) + ") \n" +
47        "where rnum  >= " + offset;
48
49    try {
  10. sql_sink: Passing the tainted value query to the SQL API java.sql.Connection.prepareStatement(java.lang.String) may allow an attacker to inject SQL.
50      return db.prepareStatement(query);
51    } catch (SQLException e) {
52      throw new IOException(e);
53    }
54
55  }

This is the one in PostgresConnector.java, lines 495-504:

 
   8. taint_path_param: Parameter searchClause receives the tainted data.
495  protected PreparedStatement getQualifiedPS(Statements statement, String searchClause) throws IOException {
496    if (db == null)
497      throw new IOException("postgres db not initialized");
498    try {
499      // LOG.debug("preparing " + statement.getStatementString() + searchClause);
   CID 167743 (#1 of 1): SQL injection (SQLI)9. sql_taint: Insecure concatenation of a SQL statement. The value searchClause is tainted. Passing the tainted command to the SQL API java.sql.Connection.prepareStatement(java.lang.String) may allow an attacker to inject SQL.
   Perform one of the following to guard against SQL injection attacks.

    Parameterize the SQL statement using ? positional characters. Bind the tainted values to the ? positional parameters using one of the PreparedStatement.set* methods.
    Validate user-supplied values against predefined constant values. Concatenate these constant values into the SQL statement.
    Cast tainted values to safe types such as integers. Concatenate these type safe values into the statement.

More Information
500      return db.prepareStatement(statement.getStatementString() + searchClause);
501    } catch (SQLException e) {
502      throw new IOException(e);
503    }
504  }

Solution
Remove code supporting an unsupported REST API call to obtain jobtracker information. his entry point is handled by org.apache.ambari.eventdb.webservice.WorkflowJsonService. By removing this class and cleaning up orphaned code, the SQL injection issue list above will be solved.

Issue Links

• links to: ReviewBoard