[AMBARI-14046] Refactor code that breaks transaction chaining

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.2.0
• Component/s: ambari-server
• Assignee: Papirkovskyy Myroslav
• Reporter: Papirkovskyy Myroslav
• Created: 24/Nov/15 16:36
• Updated: 24/Nov/15 19:44
• Resolved: 24/Nov/15 17:05

Description

Pattern issue:

   @Transactional
-  private void unmapHostClusterEntities(String hostName, long clusterId) {
+  void unmapHostClusterEntities(String hostName, long clusterId) {
     HostEntity hostEntity = hostDAO.findByName(hostName);

Transaction chaining allow graceful rollback as well as affects visibility of changes to entity objects in a DB session.

Presently a lot of chained methods have private access with @Transactional annotation which means the MethodInterceptor which provides the chaining functionality will not work and the intermediate DAO calls will persist.

Issue Links

• links to: ReviewBoard