[AMBARI-13836] NPE when enabling security during Update Configurations stage (after upgrade from 1.6.1 to 2.1.2.1)

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.1.2
• Fix Version/s: 2.2.0
• Component/s: ambari-server
• Assignee: Magyari Sandor Szilard
• Reporter: Magyari Sandor Szilard
• Created: 11/Nov/15 15:51
• Updated: 12/Nov/15 23:43
• Resolved: 12/Nov/15 19:58

Description

It appears that the NPE is coming from org/apache/ambari/server/state/ConfigHelper.java:691 when the config being processed is "storm-site".

org/apache/ambari/server/state/ConfigHelper.java:691

      if (oldConfig == null) {
        oldConfigProperties = null;
      } else {
        oldConfigProperties = oldConfig.getProperties();
        if (oldConfigProperties != null) {
          properties.putAll(oldConfig.getProperties());
        }
==> propertiesAttributes.putAll(oldConfig.getPropertiesAttributes());
      }

When the config type is "storm-site", oldConfig.getPropertiesAttributes() returns null since the clusterconfig.config_attributes value is null.

Most other relevant records (latest version of the config type) have and empty JSON structure (not null). Except for "hbase-log4j", "hdfs-log4j", hive-exec-log4j", "hive-log4j", "mapreduce2-log4j", "pig-log4j". "yarn-log4j", "zookeeper-log4j" - which don't seem to come into play at this time.

Steps to Reproduce
(this needs confirmation)

1. Deploy old version (1.6.1)
2. Make Ambari Only Upgrade to 2.1.2.1
3. Enable security

Solution
The fix for this is to make sure oldConfig.getPropertiesAttributes() != null before calling propertiesAttributes.putAll(oldConfig.getPropertiesAttributes()).