Uploaded image for project: 'Ambari'
  1. Ambari
  2. AMBARI-12877

File Browser view - Downloading a directory always creates a zip with name hdfs.zip

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.0
    • Fix Version/s: 2.1.2
    • Component/s: ambari-views
    • Labels:

      Description

      Create a directory using FIle browser view. Try to download it , it always gets downloaded with hdfs.zip – instead of the file name.

      It is much better if the zip is named after the directory that gets zipped instead of the user how owns it.

      Repro:

      1) create test1 and test2 directories
      2) click on download icon
      3) both directories will be downloaded as hdfs.zip

      Resolution :
      If multiple files/folders are downloaded then the zip file name should be hdfs.zip . But if single file or folder is downloaded then it should be named after the downloaded file.

      1. zipfile_name_file_view.patch
        5 kB
        Nitiraj Singh Rathore

        Issue Links

          Activity

          Hide
          nitiraj.rathore Nitiraj Singh Rathore added a comment -

          adding the patch file for resolving the bug

          Show
          nitiraj.rathore Nitiraj Singh Rathore added a comment - adding the patch file for resolving the bug
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12752426/zipfile_name_file_view.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in contrib/views/files.

          Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/3644//testReport/
          Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/3644//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12752426/zipfile_name_file_view.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in contrib/views/files. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/3644//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/3644//console This message is automatically generated.
          Hide
          u39kun Yusaku Sako added a comment -

          Committed to trunk and branch-2.1.

          Show
          u39kun Yusaku Sako added a comment - Committed to trunk and branch-2.1.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Ambari-trunk-Commit #3356 (See https://builds.apache.org/job/Ambari-trunk-Commit/3356/)
          AMBARI-12877. Ambari File Browser view - Downloading a directory always creates a zip with name hdfs.zip. (Nitiraj Singh Rathore via yusaku) (yusaku: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=fc64eae4f59786cb190c61a5a5156d42f90fa203)

          • contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java
          • contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Ambari-trunk-Commit #3356 (See https://builds.apache.org/job/Ambari-trunk-Commit/3356/ ) AMBARI-12877 . Ambari File Browser view - Downloading a directory always creates a zip with name hdfs.zip. (Nitiraj Singh Rathore via yusaku) (yusaku: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=fc64eae4f59786cb190c61a5a5156d42f90fa203 ) contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Ambari-branch-2.1 #450 (See https://builds.apache.org/job/Ambari-branch-2.1/450/)
          AMBARI-12877. Ambari File Browser view - Downloading a directory always creates a zip with name hdfs.zip. (Nitiraj Singh Rathore via yusaku) (yusaku: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=8959cd5b5d4ed21cfeaeb1b0fdf3d780d4ff0072)

          • contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java
          • contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Ambari-branch-2.1 #450 (See https://builds.apache.org/job/Ambari-branch-2.1/450/ ) AMBARI-12877 . Ambari File Browser view - Downloading a directory always creates a zip with name hdfs.zip. (Nitiraj Singh Rathore via yusaku) (yusaku: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=8959cd5b5d4ed21cfeaeb1b0fdf3d780d4ff0072 ) contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java

            People

            • Assignee:
              nitiraj.rathore Nitiraj Singh Rathore
              Reporter:
              nitiraj.rathore Nitiraj Singh Rathore
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development