Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.1
    • Fix Version/s: 2.1.2
    • Component/s: ambari-web
    • Labels:
      None

      Description

      methods like setDBProperty and getDBProperty work slow, if are used several times one after another. Example:

      var a = this.getDBProperty('a');
      var b = this.getDBProperty('b');
      var c = this.getDBProperty('c');
      

      Each getDBProperty-call does localStorage.getObject which may be slow if readable object is too big (it may take 100-150 ms). So, it's better to read list of values with one call, like:

      this.getDBProperties(['a', 'b', 'c']);
      

      And same for setDBProperties.

      1. AMBARI-12868_2.patch
        5 kB
        Oleg Nechiporenko
      2. AMBARI-12868_3.patch
        0.7 kB
        Oleg Nechiporenko
      3. AMBARI-12868.patch
        27 kB
        Oleg Nechiporenko

        Activity

        Hide
        onechiporenko Oleg Nechiporenko added a comment -

        6682 tests complete (12 seconds)
        94 tests pending

        Show
        onechiporenko Oleg Nechiporenko added a comment - 6682 tests complete (12 seconds) 94 tests pending
        Hide
        onechiporenko Oleg Nechiporenko added a comment -

        Patch added

        Show
        onechiporenko Oleg Nechiporenko added a comment - Patch added
        Hide
        atkach Andrii Tkach added a comment -

        +1 for the patch

        Show
        atkach Andrii Tkach added a comment - +1 for the patch
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12752210/AMBARI-12868.patch
        against trunk revision .

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/3637//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12752210/AMBARI-12868.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/3637//console This message is automatically generated.
        Hide
        onechiporenko Oleg Nechiporenko added a comment -

        Additional patch added

        Show
        onechiporenko Oleg Nechiporenko added a comment - Additional patch added
        Hide
        atkach Andrii Tkach added a comment -

        +1 for the second patch

        Show
        atkach Andrii Tkach added a comment - +1 for the second patch
        Hide
        onechiporenko Oleg Nechiporenko added a comment -

        Committed to trunk and 2.1
        Build failed not because of patch issues.

        Show
        onechiporenko Oleg Nechiporenko added a comment - Committed to trunk and 2.1 Build failed not because of patch issues.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Ambari-branch-2.1 #417 (See https://builds.apache.org/job/Ambari-branch-2.1/417/)
        AMBARI-12868. Improve calls to the localStorage (onechiporenko) (onechiporenko: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=b8e3988cbb61c19b52d0f743dfedbec542b1b7fc)

        • ambari-web/test/controllers/wizard/step7_test.js
        • ambari-web/app/routes/create_widget.js
        • ambari-web/app/routes/add_kerberos_routes.js
        • ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js
        • ambari-web/test/controllers/main/host/add_controller_test.js
        • ambari-web/app/controllers/global/cluster_controller.js
        • ambari-web/app/routes/installer.js
        • ambari-web/app/controllers/main/host/add_controller.js
        • ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js
        • ambari-web/app/controllers/wizard/step7_controller.js
        • ambari-web/app/routes/add_host_routes.js
        • ambari-web/app/mixins/wizard/wizardProgressPageController.js
        • ambari-web/test/controllers/installer_test.js
        • ambari-web/app/controllers/wizard/step8_controller.js
        • ambari-web/app/controllers/installer.js
        • ambari-web/app/controllers/wizard/step9_controller.js
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Ambari-branch-2.1 #417 (See https://builds.apache.org/job/Ambari-branch-2.1/417/ ) AMBARI-12868 . Improve calls to the localStorage (onechiporenko) (onechiporenko: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=b8e3988cbb61c19b52d0f743dfedbec542b1b7fc ) ambari-web/test/controllers/wizard/step7_test.js ambari-web/app/routes/create_widget.js ambari-web/app/routes/add_kerberos_routes.js ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js ambari-web/test/controllers/main/host/add_controller_test.js ambari-web/app/controllers/global/cluster_controller.js ambari-web/app/routes/installer.js ambari-web/app/controllers/main/host/add_controller.js ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js ambari-web/app/controllers/wizard/step7_controller.js ambari-web/app/routes/add_host_routes.js ambari-web/app/mixins/wizard/wizardProgressPageController.js ambari-web/test/controllers/installer_test.js ambari-web/app/controllers/wizard/step8_controller.js ambari-web/app/controllers/installer.js ambari-web/app/controllers/wizard/step9_controller.js
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Ambari-branch-2.1 #418 (See https://builds.apache.org/job/Ambari-branch-2.1/418/)
        AMBARI-12868. Improve calls to the localStorage (onechiporenko) (onechiporenko: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=b5018a48b930ded6e5f0c480834451ab9e1677c8)

        • ambari-web/app/controllers/main/service/add_controller.js
        • ambari-web/app/controllers/installer.js
        • ambari-web/app/controllers/main/host/add_controller.js
        • ambari-web/app/controllers/wizard.js
        • ambari-web/app/controllers/wizard/step7_controller.js
        • ambari-web/app/utils/db.js
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Ambari-branch-2.1 #418 (See https://builds.apache.org/job/Ambari-branch-2.1/418/ ) AMBARI-12868 . Improve calls to the localStorage (onechiporenko) (onechiporenko: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=b5018a48b930ded6e5f0c480834451ab9e1677c8 ) ambari-web/app/controllers/main/service/add_controller.js ambari-web/app/controllers/installer.js ambari-web/app/controllers/main/host/add_controller.js ambari-web/app/controllers/wizard.js ambari-web/app/controllers/wizard/step7_controller.js ambari-web/app/utils/db.js
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Ambari-trunk-Commit #3317 (See https://builds.apache.org/job/Ambari-trunk-Commit/3317/)
        AMBARI-12868. Improve calls to the localStorage (onechiporenko) (onechiporenko: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=e6ad02fe3144124bd640e604f438ee45cde8daf0)

        • ambari-web/app/routes/add_host_routes.js
        • ambari-web/app/routes/add_kerberos_routes.js
        • ambari-web/app/mixins/wizard/wizardProgressPageController.js
        • ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js
        • ambari-web/app/controllers/global/cluster_controller.js
        • ambari-web/test/controllers/main/host/add_controller_test.js
        • ambari-web/app/controllers/main/host/add_controller.js
        • ambari-web/test/controllers/installer_test.js
        • ambari-web/app/controllers/wizard/step9_controller.js
        • ambari-web/app/controllers/wizard/step7_controller.js
        • ambari-web/test/controllers/wizard/step7_test.js
        • ambari-web/app/routes/create_widget.js
        • ambari-web/app/controllers/wizard/step8_controller.js
        • ambari-web/app/controllers/installer.js
        • ambari-web/app/routes/installer.js
        • ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Ambari-trunk-Commit #3317 (See https://builds.apache.org/job/Ambari-trunk-Commit/3317/ ) AMBARI-12868 . Improve calls to the localStorage (onechiporenko) (onechiporenko: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=e6ad02fe3144124bd640e604f438ee45cde8daf0 ) ambari-web/app/routes/add_host_routes.js ambari-web/app/routes/add_kerberos_routes.js ambari-web/app/mixins/wizard/wizardProgressPageController.js ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js ambari-web/app/controllers/global/cluster_controller.js ambari-web/test/controllers/main/host/add_controller_test.js ambari-web/app/controllers/main/host/add_controller.js ambari-web/test/controllers/installer_test.js ambari-web/app/controllers/wizard/step9_controller.js ambari-web/app/controllers/wizard/step7_controller.js ambari-web/test/controllers/wizard/step7_test.js ambari-web/app/routes/create_widget.js ambari-web/app/controllers/wizard/step8_controller.js ambari-web/app/controllers/installer.js ambari-web/app/routes/installer.js ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Ambari-trunk-Commit #3318 (See https://builds.apache.org/job/Ambari-trunk-Commit/3318/)
        AMBARI-12868. Improve calls to the localStorage (onechiporenko) (onechiporenko: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=9b3fff2fc1fff130633f577b8429281c824baa82)

        • ambari-web/app/controllers/main/host/add_controller.js
        • ambari-web/app/controllers/installer.js
        • ambari-web/app/utils/db.js
        • ambari-web/app/controllers/wizard.js
        • ambari-web/app/controllers/wizard/step7_controller.js
        • ambari-web/app/controllers/main/service/add_controller.js
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Ambari-trunk-Commit #3318 (See https://builds.apache.org/job/Ambari-trunk-Commit/3318/ ) AMBARI-12868 . Improve calls to the localStorage (onechiporenko) (onechiporenko: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=9b3fff2fc1fff130633f577b8429281c824baa82 ) ambari-web/app/controllers/main/host/add_controller.js ambari-web/app/controllers/installer.js ambari-web/app/utils/db.js ambari-web/app/controllers/wizard.js ambari-web/app/controllers/wizard/step7_controller.js ambari-web/app/controllers/main/service/add_controller.js
        Hide
        onechiporenko Oleg Nechiporenko added a comment -

        Patch added

        Show
        onechiporenko Oleg Nechiporenko added a comment - Patch added
        Hide
        atkach Andrii Tkach added a comment -

        +1 for the patch

        Show
        atkach Andrii Tkach added a comment - +1 for the patch
        Hide
        onechiporenko Oleg Nechiporenko added a comment -

        Committed to trunk and 2.1

        Show
        onechiporenko Oleg Nechiporenko added a comment - Committed to trunk and 2.1
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Ambari-trunk-Commit #3343 (See https://builds.apache.org/job/Ambari-trunk-Commit/3343/)
        AMBARI-12868. Improve calls to the localStorage (onechiporenko) (onechiporenko: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=6fc31441476879fb668bc47f6d0c00d18cba4fd7)

        • ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Ambari-trunk-Commit #3343 (See https://builds.apache.org/job/Ambari-trunk-Commit/3343/ ) AMBARI-12868 . Improve calls to the localStorage (onechiporenko) (onechiporenko: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=6fc31441476879fb668bc47f6d0c00d18cba4fd7 ) ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Ambari-branch-2.1 #440 (See https://builds.apache.org/job/Ambari-branch-2.1/440/)
        AMBARI-12868. Improve calls to the localStorage (onechiporenko) (onechiporenko: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=33c694b181c5c1c10293bc4ecf008d54960fc23b)

        • ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Ambari-branch-2.1 #440 (See https://builds.apache.org/job/Ambari-branch-2.1/440/ ) AMBARI-12868 . Improve calls to the localStorage (onechiporenko) (onechiporenko: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=33c694b181c5c1c10293bc4ecf008d54960fc23b ) ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js

          People

          • Assignee:
            onechiporenko Oleg Nechiporenko
            Reporter:
            onechiporenko Oleg Nechiporenko
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development