Uploaded image for project: 'Ambari'
  1. Ambari
  2. AMBARI-12179

Tez View should automatically configuration settings based on http/https policy

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1.1
    • Component/s: None
    • Labels:
      None

      Description

      The current tez view impl always defaults to the http addresses instead of relying on the http policy setting.

      1. AMBARI-12179.4.patch
        5 kB
        Hitesh Shah
      2. AMBARI-12179.3.view-xml_unchanged.patch
        5 kB
        Hitesh Shah
      3. AMBARI-12179.3.patch
        7 kB
        Hitesh Shah
      4. AMBARI-12179.2.patch
        7 kB
        Hitesh Shah
      5. AMBARI-12179.1.patch
        7 kB
        Hitesh Shah

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12742248/AMBARI-12179.2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in contrib/views/tez.

        Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/3289//testReport/
        Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/3289//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12742248/AMBARI-12179.2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in contrib/views/tez. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/3289//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/3289//console This message is automatically generated.
        Hide
        mahadev Mahadev konar added a comment -

        +1 the patch looks good. Hitesh Shah wnat to go ahead and commit to trunk adn branch-2.1?

        Show
        mahadev Mahadev konar added a comment - +1 the patch looks good. Hitesh Shah wnat to go ahead and commit to trunk adn branch-2.1?
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Hitesh Shah
        Current patch doesn't prepend http protocol if the same is not set in configuration xmls.
        It just takes the value as it is.

        +      } else {
        +        value = cluster.getConfigurationValue(TYPE_YARN_SITE,
        +            HTTP_PROPERTY_MAP.get(parameterName));
        +      }
        

        Guess its better to prepend http if the same is not found.

        Show
        Sreenath Sreenath Somarajapuram added a comment - Hitesh Shah Current patch doesn't prepend http protocol if the same is not set in configuration xmls. It just takes the value as it is. + } else { + value = cluster.getConfigurationValue(TYPE_YARN_SITE, + HTTP_PROPERTY_MAP.get(parameterName)); + } Guess its better to prepend http if the same is not found.
        Hide
        hitesh Hitesh Shah added a comment -

        Patch updated to address Sreenath Somarajapuram's comment.

        Show
        hitesh Hitesh Shah added a comment - Patch updated to address Sreenath Somarajapuram 's comment.
        Hide
        hitesh Hitesh Shah added a comment -

        Same as patch 3 except for changes in view.xml reverted due to Ambari bug.

        Show
        hitesh Hitesh Shah added a comment - Same as patch 3 except for changes in view.xml reverted due to Ambari bug.
        Hide
        hitesh Hitesh Shah added a comment -

        Sreenath Somarajapuram Mind trying out the 3rd patch ( with view-xml unchanged ) ?

        Show
        hitesh Hitesh Shah added a comment - Sreenath Somarajapuram Mind trying out the 3rd patch ( with view-xml unchanged ) ?
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12748872/AMBARI-12179.3.view-xml_unchanged.patch
        against trunk revision .

        -1 patch. Top-level trunk compilation may be broken.

        Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/3531//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12748872/AMBARI-12179.3.view-xml_unchanged.patch against trunk revision . -1 patch . Top-level trunk compilation may be broken. Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/3531//console This message is automatically generated.
        Hide
        hitesh Hitesh Shah added a comment -

        Re-uploading patch

        Show
        hitesh Hitesh Shah added a comment - Re-uploading patch
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12748872/AMBARI-12179.3.view-xml_unchanged.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in contrib/views/tez.

        Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/3532//testReport/
        Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/3532//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12748872/AMBARI-12179.3.view-xml_unchanged.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in contrib/views/tez. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/3532//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/3532//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12748873/AMBARI-12179.3.view-xml_unchanged.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in contrib/views/tez.

        Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/3533//testReport/
        Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/3533//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12748873/AMBARI-12179.3.view-xml_unchanged.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in contrib/views/tez. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/3533//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/3533//console This message is automatically generated.
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Thanks you Hitesh Shah.
        +1 LGTM

        View build with AMBARI-12179.3.view-xml_unchanged.patch was tested over Ambari-2.1 and things works as expected.

        Show
        Sreenath Sreenath Somarajapuram added a comment - Thanks you Hitesh Shah . +1 LGTM View build with AMBARI-12179 .3.view-xml_unchanged.patch was tested over Ambari-2.1 and things works as expected.
        Hide
        hitesh Hitesh Shah added a comment -

        Re-uploading view-xml unchanged as patch 4 to keep things clear.

        Show
        hitesh Hitesh Shah added a comment - Re-uploading view-xml unchanged as patch 4 to keep things clear.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12749161/AMBARI-12179.4.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in contrib/views/tez.

        Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/3542//testReport/
        Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/3542//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12749161/AMBARI-12179.4.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in contrib/views/tez. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/3542//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/3542//console This message is automatically generated.
        Hide
        sumitmohanty Sumit Mohanty added a comment -

        +1

        Show
        sumitmohanty Sumit Mohanty added a comment - +1
        Hide
        sumitmohanty Sumit Mohanty added a comment -

        committed to trunk and branch-2.1

        Show
        sumitmohanty Sumit Mohanty added a comment - committed to trunk and branch-2.1
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Ambari-branch-2.1 #342 (See https://builds.apache.org/job/Ambari-branch-2.1/342/)
        AMBARI-12179. Tez View should automatically configuration settings based on http/https policy (Hitesh Shah via smohanty) (smohanty: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=ef222969d17c28fe6f57c1083932378d19e9980c)

        • contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewControllerImpl.java
        • contrib/views/tez/src/main/java/org/apache/ambari/view/tez/PropertyService.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Ambari-branch-2.1 #342 (See https://builds.apache.org/job/Ambari-branch-2.1/342/ ) AMBARI-12179 . Tez View should automatically configuration settings based on http/https policy (Hitesh Shah via smohanty) (smohanty: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=ef222969d17c28fe6f57c1083932378d19e9980c ) contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewControllerImpl.java contrib/views/tez/src/main/java/org/apache/ambari/view/tez/PropertyService.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Ambari-trunk-Commit #3242 (See https://builds.apache.org/job/Ambari-trunk-Commit/3242/)
        AMBARI-12179. Tez View should automatically configuration settings based on http/https policy (Hitesh Shah via smohanty) (smohanty: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=f1550245cf3ae345ace6073096476fddc64f9280)

        • contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewControllerImpl.java
        • contrib/views/tez/src/main/java/org/apache/ambari/view/tez/PropertyService.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Ambari-trunk-Commit #3242 (See https://builds.apache.org/job/Ambari-trunk-Commit/3242/ ) AMBARI-12179 . Tez View should automatically configuration settings based on http/https policy (Hitesh Shah via smohanty) (smohanty: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=f1550245cf3ae345ace6073096476fddc64f9280 ) contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewControllerImpl.java contrib/views/tez/src/main/java/org/apache/ambari/view/tez/PropertyService.java

          People

          • Assignee:
            hitesh Hitesh Shah
            Reporter:
            hitesh Hitesh Shah
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development