[AIRAVATA-3022] When an experiment is launched twice (user clicks Launch button twice) the experiment is tagged as FAILED where as the job submission proceeds.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.18
• Fix Version/s: 0.18
• Component/s: Airavata API, PGA PHP Web Gateway
• Environment: seagrid.org
• Assignee: Dimuthu
• Reporter: Eroma
• Created: 17/Apr/19 19:35
• Updated: 03/Jun/19 20:20
• Resolved: 03/May/19 15:41

Description

1. User clones an experiment and launches it using the Launch button. The user clicks on the Launch button again which tries to launch the already launched experiment again,
2. This scenario is currently handled by tagging the experiment with FAILED.
3. What is required is graceful handling of the situation and not to tag the already launched experiment as FAILED, but to leave it in LAUNCHED 
4. Although the experiment is tagged as FAILED at the second LAUNCH attempt, the job has got submitted since the experiment was already LAUNCHED.
5. The errors in the api log
6. 2019-04-17 14:40:55,414 [pool-9-thread-93] ERROR o.a.thrift.ProcessFunction - Internal error processing updateExperiment
   org.apache.airavata.model.error.AiravataSystemException: Error while updating experiment. Update experiment is only valid for experiments with status CREATED, VALIDATED, CANCELLED, FAILED and UNKNOWN. Make sure the given experiment is in one of above statuses...
   at org.apache.airavata.registry.api.service.handler.RegistryServerHandler.updateExperiment(RegistryServerHandler.java:3159)
   at org.apache.airavata.registry.api.RegistryService$Processor$updateExperiment.getResult(RegistryService.java:12745)
   at org.apache.airavata.registry.api.RegistryService$Processor$updateExperiment.getResult(RegistryService.java:12729)
   at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:39)
   at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:39)
   at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:286)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
   at java.lang.Thread.run(Thread.java:748)
   2019-04-17 14:40:55,414 [pool-24-thread-51] ERROR o.a.a.a.s.h.AiravataServerHandler - Clone_of_Pinacyanol_3472ac7b-1900-4ed6-95e4-7f7443d65701
   org.apache.thrift.TApplicationException: Internal error processing updateExperiment
   at org.apache.thrift.TApplicationException.read(TApplicationException.java:111)
   at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:79)
   at org.apache.airavata.registry.api.RegistryService$Client.recv_updateExperiment(RegistryService.java:3577)
   at org.apache.airavata.registry.api.RegistryService$Client.updateExperiment(RegistryService.java:3563)
   at org.apache.airavata.api.server.handler.AiravataServerHandler.updateExperiment(AiravataServerHandler.java:1568)
   at org.apache.airavata.api.server.handler.AiravataServerHandler$$EnhancerByGuice$$a6c02c04.CGLIB$updateExperiment$144(<generated>)
   at org.apache.airavata.api.server.handler.AiravataServerHandler$$EnhancerByGuice$$a6c02c04$$FastClassByGuice$$85becf93.invoke(<generated>)
   at com.google.inject.internal.cglib.proxy.$MethodProxy.invokeSuper(MethodProxy.java:228)
   at com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:75)
   at org.apache.airavata.service.security.interceptor.SecurityInterceptor.invoke(SecurityInterceptor.java:57)
   at com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:75)
   at com.google.inject.internal.InterceptorStackCallback.intercept(InterceptorStackCallback.java:55)
   at org.apache.airavata.api.server.handler.AiravataServerHandler$$EnhancerByGuice$$a6c02c04.updateExperiment(<generated>)
   at org.apache.airavata.api.Airavata$Processor$updateExperiment.getResult(Airavata.java:17637)
   at org.apache.airavata.api.Airavata$Processor$updateExperiment.getResult(Airavata.java:17621)
   at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:39)
   at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:39)
   at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:286)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
   at java.lang.Thread.run(Thread.java:748)

Issue Links

• relates to: AIRAVATA-3061 exp FAILED and job in ACTIVE