[AGE2-353] [Apache AGE] Remove obsolete components from CREATE, SET, & DELETE

• Type: Improvement
• Status: Done
• Priority: Normal
• Resolution: Done
• Fix Version/s: 0.5.0, 0.6.0
• Labels: improvement refactor
• Assignee: John Gemignani
• Reporter: John Gemignani
• Created: 21/Aug/21 01:11
• Updated: 28/Sep/21 23:11
• Resolved: 28/Sep/21 23:11

Description

After completion of AGE2-345, AGE2-348, and AGE2-349, research if it is possible to remove the following from CREATE, SET, & DELETE's execution logic -

    /*
     * Postgres does not assign the es_output_cid in queries that do
     * not write to disk, ie: SELECT commands. We need the command id
     * for our clauses, and we may need to initialize it. We cannot use
     * GetCurrentCommandId because there may be other cypher clauses
     * that have modified the command id.
     */
    if (estate->es_output_cid == 0)
        estate->es_output_cid = estate->es_snapshot->curcid;

It shouldn't be necessary once all 3 are done but, we need to be sure.

Implement any additional fixes and remove it.

 

Issue Links

• is blocked by: AGE2-345 [Apache AGE] CREATE has incorrect visibility in transaction blocks
• is blocked by: AGE2-348 [Apache AGE] SET may benefit from improvements made to CREATE
• is blocked by: AGE2-349 [Apache AGE] DELETE may benefit from improvements made to CREATE