Uploaded image for project: 'ActiveMQ Artemis'
  1. ActiveMQ Artemis
  2. ARTEMIS-6

Extract any JBoss SPI code replace with generic

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.0.0
    • None
    • None

    Attachments

      Activity

        Mainly: the RA needs to be totally generic. That way it can work well on any application server.

        I'm not going to create a separate task just for cleaning the RA as we have this task here... if we make sure the RA is cleaned we won't need another task.

        clebertsuconic Clebert Suconic added a comment - Mainly: the RA needs to be totally generic. That way it can work well on any application server. I'm not going to create a separate task just for cleaning the RA as we have this task here... if we make sure the RA is cleaned we won't need another task.
        martyntaylor Martyn Taylor added a comment -

        According to the pom.xml there are one or two cases where the SPIs are being used outside of the RA: I've pasted excerpt below. This task should encompass removing these SPIs in addition to removing those used in the RA.

        <!-this specifically for the JMS Bridge->
        <dependency>
        <groupId>org.jboss</groupId>
        <artifactId>jboss-transaction-spi</artifactId>
        <version>7.0.0.Final</version>
        <exclusions>
        <exclusion>
        <groupId>org.jboss.logging</groupId>
        <artifactId>jboss-logging-spi</artifactId>
        </exclusion>
        </exclusions>
        </dependency>

        martyntaylor Martyn Taylor added a comment - According to the pom.xml there are one or two cases where the SPIs are being used outside of the RA: I've pasted excerpt below. This task should encompass removing these SPIs in addition to removing those used in the RA. <!- this specifically for the JMS Bridge -> <dependency> <groupId>org.jboss</groupId> <artifactId>jboss-transaction-spi</artifactId> <version>7.0.0.Final</version> <exclusions> <exclusion> <groupId>org.jboss.logging</groupId> <artifactId>jboss-logging-spi</artifactId> </exclusion> </exclusions> </dependency>
        martyntaylor Martyn Taylor added a comment -

        The following third party deps have been identified as having Cat X licenses. Please take these into consideration when performing this task.

        CatX Licenses:.

        Artifact: org.jboss.jboss-transaction-spi
        License: LGPL
        Notes: Will be removed as part of: https://issues.apache.org/jira/browse/ACTIVEMQ6-6

        Artifact: org.jboss.jbossts.jts.jbossjts-jacorb
        License: LGPL
        Notes: Will be removed as part of: https://issues.apache.org/jira/browse/ACTIVEMQ6-6

        Artifact: org.jboss.ironjacamar.ironjacamar-core-api
        License: LGPL
        Notes: Will be removed as part of: https://issues.apache.org/jira/browse/ACTIVEMQ6-6

        Artifact: jboss.jbossts.jbossts-common
        License: LGPL
        Notes: Apparently JMS Tests need this. Needs some investigation.

        Artifact: org.jboss.security.jbosssx
        Lisence: LGPL
        Notes; Both JMS Tests and JBoss Integration are dependent on this. Needs some work to pull out dependent tests and intvestigation into integration module. Do we want to keep this hanging around?

        Artifact:>org.jboss.security.boss-security-spi
        Lisence: LGPL

        Artifact: org.jboss.ejb3.jboss-ejb3-ext-api
        License: LGPL
        Notes: javaee examples require this. Do we want javaee examples to hang around here. These may be best suited outside of activemq repository as they appear to be somewhat Jboss specific.

        martyntaylor Martyn Taylor added a comment - The following third party deps have been identified as having Cat X licenses. Please take these into consideration when performing this task. CatX Licenses:. Artifact: org.jboss.jboss-transaction-spi License: LGPL Notes: Will be removed as part of: https://issues.apache.org/jira/browse/ACTIVEMQ6-6 Artifact: org.jboss.jbossts.jts.jbossjts-jacorb License: LGPL Notes: Will be removed as part of: https://issues.apache.org/jira/browse/ACTIVEMQ6-6 Artifact: org.jboss.ironjacamar.ironjacamar-core-api License: LGPL Notes: Will be removed as part of: https://issues.apache.org/jira/browse/ACTIVEMQ6-6 Artifact: jboss.jbossts.jbossts-common License: LGPL Notes: Apparently JMS Tests need this. Needs some investigation. Artifact: org.jboss.security.jbosssx Lisence: LGPL Notes; Both JMS Tests and JBoss Integration are dependent on this. Needs some work to pull out dependent tests and intvestigation into integration module. Do we want to keep this hanging around? Artifact:>org.jboss.security.boss-security-spi Lisence: LGPL Artifact: org.jboss.ejb3.jboss-ejb3-ext-api License: LGPL Notes: javaee examples require this. Do we want javaee examples to hang around here. These may be best suited outside of activemq repository as they appear to be somewhat Jboss specific.

        We may run a vote.. but IMHO we should keep the javaee examples.. By 6.1 they should be generic on any application server

        clebertsuconic Clebert Suconic added a comment - We may run a vote.. but IMHO we should keep the javaee examples.. By 6.1 they should be generic on any application server
        githubbot ASF GitHub Bot added a comment -

        GitHub user mtaylor opened a pull request:

        https://github.com/apache/activemq-6/pull/23

        ACTIVEMQ6-6 Add Service Extension Component

        Adds a new service extensions components used to house any extension
        points for integration and extension. In addition this patch adds
        initial extension points for XAResource wrapping.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/mtaylor/activemq-6 spi_work

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/activemq-6/pull/23.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #23


        commit 735b4030cfd86f48d2bcf4ca026fb2a2d0d84503
        Author: Martyn Taylor <mtaylor@redhat.com>
        Date: 2014-11-25T12:20:20Z

        ACTIVEMQ6-6 Add Service Extension Component

        Adds a new service extensions components used to house any extension
        points for integration and extension. In addition this patch adds
        initial extension points for XAResource wrapping.


        githubbot ASF GitHub Bot added a comment - GitHub user mtaylor opened a pull request: https://github.com/apache/activemq-6/pull/23 ACTIVEMQ6-6 Add Service Extension Component Adds a new service extensions components used to house any extension points for integration and extension. In addition this patch adds initial extension points for XAResource wrapping. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mtaylor/activemq-6 spi_work Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-6/pull/23.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #23 commit 735b4030cfd86f48d2bcf4ca026fb2a2d0d84503 Author: Martyn Taylor <mtaylor@redhat.com> Date: 2014-11-25T12:20:20Z ACTIVEMQ6-6 Add Service Extension Component Adds a new service extensions components used to house any extension points for integration and extension. In addition this patch adds initial extension points for XAResource wrapping.
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/activemq-6/pull/23

        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/activemq-6/pull/23
        githubbot ASF GitHub Bot added a comment -

        GitHub user andytaylor opened a pull request:

        https://github.com/apache/activemq-6/pull/36

        ACTIVEMQ6-6 - remove SPI usage

        https://issues.apache.org/jira/browse/ACTIVEMQ6-6

        Removed the jboss security implementations and also implemented the location of Transaction Managers using Service Loader and removed the jboss implementation.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/andytaylor/activemq-6 master

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/activemq-6/pull/36.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #36


        commit 78a34c3ca487ea54229f38ac44b22f088d32b2a5
        Author: Andy Taylor <andytaylor@apache.org>
        Date: 2014-12-06T10:59:17Z

        ACTIVEMQ6-6 - remove SPI usage

        https://issues.apache.org/jira/browse/ACTIVEMQ6-6

        Removed the jboss security implementations and also implemented the location of Transaction Managers using Service Loader and removed the jboss implementation.


        githubbot ASF GitHub Bot added a comment - GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-6/pull/36 ACTIVEMQ6-6 - remove SPI usage https://issues.apache.org/jira/browse/ACTIVEMQ6-6 Removed the jboss security implementations and also implemented the location of Transaction Managers using Service Loader and removed the jboss implementation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/andytaylor/activemq-6 master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-6/pull/36.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #36 commit 78a34c3ca487ea54229f38ac44b22f088d32b2a5 Author: Andy Taylor <andytaylor@apache.org> Date: 2014-12-06T10:59:17Z ACTIVEMQ6-6 - remove SPI usage https://issues.apache.org/jira/browse/ACTIVEMQ6-6 Removed the jboss security implementations and also implemented the location of Transaction Managers using Service Loader and removed the jboss implementation.
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/activemq-6/pull/36

        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/activemq-6/pull/36

        Isn't this done?

        clebertsuconic Clebert Suconic added a comment - Isn't this done?

        People

          Unassigned Unassigned
          martyntaylor Martyn Taylor
          Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

            Created:
            Updated:
            Resolved: