Details
-
Improvement
-
Status: Open
-
Major
-
Resolution: Unresolved
-
None
-
None
-
None
Description
When the server is unreachable there is a lot of logging (including stack traces see example below) on the target.
I think printing stack traces here makes doesn't add much value here that would make the logs a bit smaller already.
But in case of a longer period of connectivity loss this could still be a lot, maybe a connectivity check that only logs a "no connectivity" message once in a while would be nice.
2017.11.01 19:25:03 ERROR - Bundle: org.apache.ace.agent - Agent update aborted due to Exception. - java.io.IOException: Unable to handle server responsecode: -1, for http://localhost:8081/agent/target-1/org.apache.ace.agent/versions/ at org.apache.ace.agent.impl.ConnectionUtil.checkConnectionResponse(ConnectionUtil.java:67) at org.apache.ace.agent.impl.UpdateHandlerBase.getAvailableVersions(UpdateHandlerBase.java:60) at org.apache.ace.agent.impl.AgentUpdateHandlerImpl.getAvailableVersions(AgentUpdateHandlerImpl.java:67) at org.apache.ace.agent.impl.UpdateHandlerBase.getHighestAvailableVersion(UpdateHandlerBase.java:49) at org.apache.ace.agent.impl.DefaultController$UpdateInstaller.installUpdate(DefaultController.java:238) at org.apache.ace.agent.impl.DefaultController.runAgentUpdate(DefaultController.java:598) at org.apache.ace.agent.impl.DefaultController.run(DefaultController.java:463) at org.apache.ace.agent.impl.AgentContextImpl$1.run(AgentContextImpl.java:252) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) 2017.11.01 19:25:03 WARNING - Bundle: org.apache.ace.agent - Exception while sending feedback for channel: auditlog - java.net.ConnectException: Connection refused (Connection refused) at java.net.PlainSocketImpl.socketConnect(Native Method) at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350) at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206) at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188) at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392) at java.net.Socket.connect(Socket.java:589) at java.net.Socket.connect(Socket.java:538) at sun.net.NetworkClient.doConnect(NetworkClient.java:180) at sun.net.www.http.HttpClient.openServer(HttpClient.java:432) at sun.net.www.http.HttpClient.openServer(HttpClient.java:527) at sun.net.www.http.HttpClient.<init>(HttpClient.java:211) at sun.net.www.http.HttpClient.New(HttpClient.java:308) at sun.net.www.http.HttpClient.New(HttpClient.java:326) at sun.net.www.protocol.http.HttpURLConnection.getNewHttpClient(HttpURLConnection.java:1202) at sun.net.www.protocol.http.HttpURLConnection.plainConnect0(HttpURLConnection.java:1138) at sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:1032) at sun.net.www.protocol.http.HttpURLConnection.connect(HttpURLConnection.java:966) at sun.net.www.protocol.http.HttpURLConnection.getOutputStream0(HttpURLConnection.java:1316) at sun.net.www.protocol.http.HttpURLConnection.getOutputStream(HttpURLConnection.java:1291) at org.apache.ace.agent.impl.FeedbackChannelImpl.sendFeedback(FeedbackChannelImpl.java:98) at org.apache.ace.agent.impl.DefaultController.runFeedback(DefaultController.java:637) at org.apache.ace.agent.impl.DefaultController.run(DefaultController.java:462) at org.apache.ace.agent.impl.AgentContextImpl$1.run(AgentContextImpl.java:252) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) 2017.11.01 19:24:53 ERROR - Bundle: org.apache.ace.agent - Deployment update aborted due to Exception. - java.io.IOException: Unable to handle server responsecode: -1, for http://localhost:8081/deployment/target-1/versions/ at org.apache.ace.agent.impl.ConnectionUtil.checkConnectionResponse(ConnectionUtil.java:67) at org.apache.ace.agent.impl.UpdateHandlerBase.getAvailableVersions(UpdateHandlerBase.java:60) at org.apache.ace.agent.impl.DeploymentHandlerImpl.getAvailableVersions(DeploymentHandlerImpl.java:195) at org.apache.ace.agent.impl.UpdateHandlerBase.getHighestAvailableVersion(UpdateHandlerBase.java:49) at org.apache.ace.agent.impl.DefaultController$UpdateInstaller.installUpdate(DefaultController.java:238) at org.apache.ace.agent.impl.DefaultController.runDeploymentUpdate(DefaultController.java:617) at org.apache.ace.agent.impl.DefaultController.run(DefaultController.java:464) at org.apache.ace.agent.impl.AgentContextImpl$1.run(AgentContextImpl.java:252) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745)