Uploaded image for project: 'Accumulo'
  1. Accumulo
  2. ACCUMULO-4820

Cleanup code for 2.0

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 2.0.0
    • 2.0.0
    • None

    Description

      Running IntelliJ code inspect picks up a lot of minor code clean up fixes that we would be nice to fix sooner rather than later.
      Java 5 Updates

      • unnecessary boxing
      • use foreach where possible

      Java 7 Updates (these should definitely be fixed)

      • Explicit type can be replaced with <> (aka diamond operator)
      • Identical catch branches in try
      • try finally replaceable with try with resources

      Java 8 Updates (these would be nice, but maybe some prefer older way?)

      • Replace anonymous types with lambda
      • Replace code with new single Map method call
      • Replace Collections.sort () with List.sort()

      Other Misc performance Issues picked up by the inspector. I think these should definitely be fixed but perhaps a sub ticket

      Attachments

        Activity

          People

            milleruntime Michael Miller
            milleruntime Michael Miller
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 40m
                40m