Uploaded image for project: 'Accumulo'
  1. Accumulo
  2. ACCUMULO-4710

Replace use of Guava hash package

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Not A Problem
    • 1.8.1
    • None
    • None
    • None

    Description

      We use a few of the Guava classes from the com.google.common.hash package, all of which are Beta as of Guava release 23. These should be replaced with standard Java code to prevent future issues.

      This should definitely be fixed in 2.0 but I am not sure if it would break sampling in already released versions of 1.8. There shouldn't be any Guava Beta in 1.7.

      Here are the classes used in 2.0:

      ./core/src/test/java/org/apache/accumulo/core/file/rfile/RFileTest.java:import com.google.common.hash.HashCode;
      ./core/src/test/java/org/apache/accumulo/core/file/rfile/RFileTest.java:import com.google.common.hash.Hasher;
      ./core/src/test/java/org/apache/accumulo/core/file/rfile/RFileTest.java:import com.google.common.hash.Hashing;
      ./core/src/main/java/org/apache/accumulo/core/summary/Gatherer.java:import com.google.common.hash.Hashing;
      ./core/src/main/java/org/apache/accumulo/core/client/summary/SummarizerConfiguration.java:import com.google.common.hash.Hasher;
      ./core/src/main/java/org/apache/accumulo/core/client/summary/SummarizerConfiguration.java:import com.google.common.hash.Hashing;
      ./core/src/main/java/org/apache/accumulo/core/client/sample/AbstractHashSampler.java:import com.google.common.hash.HashFunction;
      ./core/src/main/java/org/apache/accumulo/core/client/sample/AbstractHashSampler.java:import com.google.common.hash.Hasher;
      ./core/src/main/java/org/apache/accumulo/core/client/sample/AbstractHashSampler.java:import com.google.common.hash.Hashing;
      ./core/src/main/java/org/apache/accumulo/core/sample/impl/DataoutputHasher.java:import com.google.common.hash.Hasher;
      

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              milleruntime Michael Miller
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: