Uploaded image for project: 'Accumulo'
  1. Accumulo
  2. ACCUMULO-4337

Native Libraries execute tests even when configured to skip

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Won't Fix
    • 1.7.1
    • None
    • build, native
    • None

    Description

      The native libs will always execute the tests, even when -DskipTests or -Dmaven.test.skip is passed.

      Attachments

        Activity

          The native libs don't really have proper tests. Just a few sanity checks which were baked in during development and which are executed with make test. I made the native build call make test, because it seemed like an appropriate target, but it would actually significantly increase the bloat of the pom.xml if we created two separate executions, one for make and another for make test.

          I don't really think it's worth separating them (primarily because of the pom bloat) since they only add a minuscule amount of time to run, and they should always work if the library built correctly.

          ctubbsii Christopher Tubbs added a comment - The native libs don't really have proper tests. Just a few sanity checks which were baked in during development and which are executed with make test . I made the native build call make test , because it seemed like an appropriate target, but it would actually significantly increase the bloat of the pom.xml if we created two separate executions, one for make and another for make test . I don't really think it's worth separating them (primarily because of the pom bloat) since they only add a minuscule amount of time to run, and they should always work if the library built correctly.

          Haven't received feedback from the reporter or anybody else since my comment 2 weeks ago, so I'm going to mark this as "Won't Fix", according to my comment that I don't think it's worth avoiding execution of these tests with separate exec-maven-plugin executions for make.

          ctubbsii Christopher Tubbs added a comment - Haven't received feedback from the reporter or anybody else since my comment 2 weeks ago, so I'm going to mark this as "Won't Fix", according to my comment that I don't think it's worth avoiding execution of these tests with separate exec-maven-plugin executions for make .

          People

            ctubbsii Christopher Tubbs
            mdrob Mike Drob
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: