Uploaded image for project: 'Accumulo'
  1. Accumulo
  2. ACCUMULO-4334

TabletServerMetricsUtil.getIngest should return ingest rate not entries in memory

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.6.5
    • Fix Version/s: 1.6.6, 1.7.2, 1.8.0
    • Component/s: None
    • Labels:
      None

      Description

      TabletServerMetricsUtil getIngest should return ingest rate not entries in memory.

      Currently, the utility TabletServerMetricsUtil that exposes ingest rate is calculating the rate as entries in memory for each node. This should be changed to something more akin to: https://github.com/apache/accumulo/blob/master/server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java#L1410. Which will calculate the ingest rate per tablet.

        Issue Links

          Activity

          Hide
          elserj Josh Elser added a comment -

          cc/ Mike Drob, Christopher Tubbs Tentatively tagged 1.6.6 and 1.7.2. I think this would be a simple fix to get in for both releases coming up.

          Show
          elserj Josh Elser added a comment - cc/ Mike Drob , Christopher Tubbs Tentatively tagged 1.6.6 and 1.7.2. I think this would be a simple fix to get in for both releases coming up.
          Hide
          mdrob Mike Drob added a comment -

          Pushed out to 1.7.3. If this does make it into 1.7.2, we can always move it back, but I'd like to avoid trying to add things at the last minute.

          Show
          mdrob Mike Drob added a comment - Pushed out to 1.7.3. If this does make it into 1.7.2, we can always move it back, but I'd like to avoid trying to add things at the last minute.
          Hide
          elserj Josh Elser added a comment -

          Alright, thanks Mike Drob. I'll try to make this happen (it bothers me to have very wrong metrics coming out), but I understand your perspective. I'll update things if I get it done.

          Show
          elserj Josh Elser added a comment - Alright, thanks Mike Drob . I'll try to make this happen (it bothers me to have very wrong metrics coming out), but I understand your perspective. I'll update things if I get it done.
          Hide
          ctubbsii Christopher Tubbs added a comment -

          Either way, the release manager is going to re-tag any 1.7.3 resolved issues as 1.7.2, and bump any unresolved 1.7.2 issues to 1.7.3, before they cut an RC. So, it doesn't really matter how it's labeled at this point. The patch could be pulled in at any time.

          Show
          ctubbsii Christopher Tubbs added a comment - Either way, the release manager is going to re-tag any 1.7.3 resolved issues as 1.7.2, and bump any unresolved 1.7.2 issues to 1.7.3, before they cut an RC. So, it doesn't really matter how it's labeled at this point. The patch could be pulled in at any time.
          Hide
          ctubbsii Christopher Tubbs added a comment -

          Well, never mind. That was a late comment. This issue was already updated, since Dylan merged it in already

          Show
          ctubbsii Christopher Tubbs added a comment - Well, never mind. That was a late comment. This issue was already updated, since Dylan merged it in already

            People

            • Assignee:
              dhutchis Dylan Hutchison
              Reporter:
              roshanpunnoose Roshan Punnoose
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 2h 10m
                2h 10m

                  Development