[ACCUMULO-3856] ProxyServer.updateAndFlush leaks BatchWriter

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.6.1, 1.6.2, 1.7.0
• Fix Version/s: 1.5.3, 1.6.3, 1.7.1, 1.8.0
• Component/s: proxy
• Assignee: Josh Elser
• Reporter: Josh Elser
• Created: 27/May/15 19:07
• Updated: 10/Jun/15 18:02
• Resolved: 28/May/15 19:00

Description

updateAndFlush creates a new BatchWriter, adds the updates, then tries to flush and close the BatchWriter.

If the flush or addMutations fails (such as the case in SimpleProxyBase ITs where we make sure that constraints fire), this will leak that BatchWriter threads.

The BatchWriter should be closed in a finally block.