[ACCUMULO-3855] ProxyServer.update fails silently if batchwriter doesn't exist

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Won't Fix
• Component/s: proxy
• Assignee: Unassigned
• Reporter: Josh Elser
• Created: 27/May/15 18:54
• Updated: 29/May/15 21:34
• Resolved: 29/May/15 21:34

Description

Inspecting ProxyServer, saw the following:

  @Override
  public void update(String writer, Map<ByteBuffer,List<ColumnUpdate>> cells) throws TException {
    try {
      BatchWriterPlusException bwpe = getWriter(writer);
      addCellsToWriter(cells, bwpe);
    } catch (UnknownWriter e) {
      // just drop it, this is a oneway thrift call and throwing a TException seems to make all subsequent thrift calls fail
    }
  }

This means that calls to update which fail to get a BatchWriter (for whatever reason) will silently fail and appear to the user to have written data successfully. This is horrible.

I'm not sure what the comment means either. I'm not sure why throwing a TException from the server would invalidate the connection, but perhaps I'm just ignorant of some finer details.