Uploaded image for project: 'Accumulo'
  1. Accumulo
  2. ACCUMULO-3172

mavanagaiata plugin marks releases "dirty"

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Blocker
    • Resolution: Fixed
    • None
    • 1.5.3, 1.6.2, 1.7.0
    • build
    • None

    Description

      The mavanagaiata plugin we use to populate the build number in the META-INF/MANIFEST.MF file appends "-dirty" to the git commit hash. I believe this is probably done because the release plugin is adding additional files to the working branch, but I can't be sure.

      We should alter the build such that the MANIFEST.MF files don't indicate it was built from a dirty state when it wasn't.

      Further, if possible, we should fail the release:prepare goal if it tries to build from a dirty state initially. I know this was a feature of the buildnumber-maven-plugin, but it doesn't appear to be an option for this mavanagaiata one (why did we switch when we added this field back to the manifest files?)

      See https://github.com/koraktor/mavanagaiata/issues/34

      Attachments

        Issue Links

          Activity

            People

              ctubbsii Christopher Tubbs
              ctubbsii Christopher Tubbs
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h