Accumulo
  1. Accumulo
  2. ACCUMULO-2983

Separate javascript resources (jquery, flot) from monitor

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 1.8.0
    • Component/s: monitor
    • Labels:
      None

      Description

      The javascript resources (namely jquery, and flot) are included directly in the monitor jar, for inclusion on the classpath. The monitor then loads these resources, as needed, from the classpath.

      Since these are third-party libraries, it may be better to include them as a dependency, and put them in the lib directory.

      At the very least, this would help with downstream packaging, especially in situations where third-party libraries cannot be included in a package, but it may help in other situations, if we need to swap out a different version of jquery/flot dependencies.

        Activity

        Hide
        Christopher Tubbs added a comment -

        For more details about why these may not be included in other packages is because (at the very least) obfuscated/minimized code is not considered free software, according to http://www.gnu.org/philosophy/free-sw.html or open source, according to http://opensource.org/osd .

        Additionally, because of these definitions, it may also mean that we shouldn't be releasing the minimized versions of these libraries in our source release. Rather, they should be minimized during the build.

        Show
        Christopher Tubbs added a comment - For more details about why these may not be included in other packages is because (at the very least) obfuscated/minimized code is not considered free software, according to http://www.gnu.org/philosophy/free-sw.html or open source, according to http://opensource.org/osd . Additionally, because of these definitions, it may also mean that we shouldn't be releasing the minimized versions of these libraries in our source release. Rather, they should be minimized during the build.
        Hide
        Josh Elser added a comment -

        Interesting. I hadn't thought about min'ified resources in that context before. Honestly, for the scope of the monitor, we're probably not really gaining anything out of serving the min'ified variants. Plus, after the first time, as long as we set the cache-control knobs, the browser shouldn't be re-requesting them after the first visit. There are a lot of other problems we'd hit with the monitor before loading of an extra 4k bytes from a JS file affect us

        Show
        Josh Elser added a comment - Interesting. I hadn't thought about min'ified resources in that context before. Honestly, for the scope of the monitor, we're probably not really gaining anything out of serving the min'ified variants. Plus, after the first time, as long as we set the cache-control knobs, the browser shouldn't be re-requesting them after the first visit. There are a lot of other problems we'd hit with the monitor before loading of an extra 4k bytes from a JS file affect us

          People

          • Assignee:
            Unassigned
            Reporter:
            Christopher Tubbs
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Development