Accumulo
  1. Accumulo
  2. ACCUMULO-2858

Inadvertently always falling back on sync

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.7.0
    • Component/s: tserver
    • Labels:
      None

      Description

      Bad conditional logic in ACCUMULO-2842 would not actually use hsync when it was configured which caused a bunch of ITs to start failing.

      Eric Newton was a huge help in figuring out where the problem was.

        Issue Links

          Activity

          Josh Elser created issue -
          Hide
          ASF subversion and git services added a comment -

          Commit 6dfcf8ff730502abe74fa5d61126ccc2f4bb30f8 in accumulo's branch refs/heads/1.5.2-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=6dfcf8f ]

          ACCUMULO-2858 Ensure that we only look for 'sync' when we couldn't load configured method

          Show
          ASF subversion and git services added a comment - Commit 6dfcf8ff730502abe74fa5d61126ccc2f4bb30f8 in accumulo's branch refs/heads/1.5.2-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=6dfcf8f ] ACCUMULO-2858 Ensure that we only look for 'sync' when we couldn't load configured method
          Hide
          ASF subversion and git services added a comment -

          Commit 6dfcf8ff730502abe74fa5d61126ccc2f4bb30f8 in accumulo's branch refs/heads/1.6.1-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=6dfcf8f ]

          ACCUMULO-2858 Ensure that we only look for 'sync' when we couldn't load configured method

          Show
          ASF subversion and git services added a comment - Commit 6dfcf8ff730502abe74fa5d61126ccc2f4bb30f8 in accumulo's branch refs/heads/1.6.1-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=6dfcf8f ] ACCUMULO-2858 Ensure that we only look for 'sync' when we couldn't load configured method
          Hide
          ASF subversion and git services added a comment -

          Commit 6dfcf8ff730502abe74fa5d61126ccc2f4bb30f8 in accumulo's branch refs/heads/master from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=6dfcf8f ]

          ACCUMULO-2858 Ensure that we only look for 'sync' when we couldn't load configured method

          Show
          ASF subversion and git services added a comment - Commit 6dfcf8ff730502abe74fa5d61126ccc2f4bb30f8 in accumulo's branch refs/heads/master from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=6dfcf8f ] ACCUMULO-2858 Ensure that we only look for 'sync' when we couldn't load configured method
          Hide
          ASF subversion and git services added a comment -

          Commit 6dfcf8ff730502abe74fa5d61126ccc2f4bb30f8 in accumulo's branch refs/heads/ACCUMULO-378 from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=6dfcf8f ]

          ACCUMULO-2858 Ensure that we only look for 'sync' when we couldn't load configured method

          Show
          ASF subversion and git services added a comment - Commit 6dfcf8ff730502abe74fa5d61126ccc2f4bb30f8 in accumulo's branch refs/heads/ ACCUMULO-378 from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=6dfcf8f ] ACCUMULO-2858 Ensure that we only look for 'sync' when we couldn't load configured method
          Josh Elser made changes -
          Field Original Value New Value
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Sean Busbey made changes -
          Link This issue relates to ACCUMULO-2842 [ ACCUMULO-2842 ]
          Hide
          Josh Elser added a comment -

          For those who might "post-humously" look at these changes, 1.5.2-SNAPSHOT and 1.6.1-SNAPSHOT weren't actually affected by this bug, it was really only 1.7.0-SNAPSHOT. However, in changing this code, I cleaned up the methods to avoid less try/catch indirection.

          I should've applied the try-catch reformatting in another ticket, but since I was knee-deep in this code, I just did it here.

          Show
          Josh Elser added a comment - For those who might "post-humously" look at these changes, 1.5.2-SNAPSHOT and 1.6.1-SNAPSHOT weren't actually affected by this bug, it was really only 1.7.0-SNAPSHOT. However, in changing this code, I cleaned up the methods to avoid less try/catch indirection. I should've applied the try-catch reformatting in another ticket, but since I was knee-deep in this code, I just did it here.
          Josh Elser made changes -
          Fix Version/s 1.6.1 [ 12325441 ]
          Fix Version/s 1.5.2 [ 12326272 ]

            People

            • Assignee:
              Josh Elser
              Reporter:
              Josh Elser
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development