Accumulo
  1. Accumulo
  2. ACCUMULO-2779

Wikisearch example should not have Accumulo as Parent

    Details

    • Type: Improvement Improvement
    • Status: Patch Available
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.5.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Since the WikiSearch example sits in its own Git repository, it should depend on Accumulo but not be a child module.

      1. accumulo-2779.patch
        8 kB
        David Medinets
      2. accumulo-2779.patch
        9 kB
        David Medinets

        Issue Links

          Activity

          David Medinets created issue -
          Hide
          David Medinets added a comment -

          This patch just changes the pom.xml files. Hopefully correctly. After these, changes I can run 'mvn clean packages' with all tests passing.

          Show
          David Medinets added a comment - This patch just changes the pom.xml files. Hopefully correctly. After these, changes I can run 'mvn clean packages' with all tests passing.
          David Medinets made changes -
          Field Original Value New Value
          Attachment accumulo-2779.patch [ 12643608 ]
          Hide
          David Medinets added a comment -

          Please review. I'm not sure that I included the right dependency versions. Just because it compiles and the tests run doesn't mean it's formally correct.

          Show
          David Medinets added a comment - Please review. I'm not sure that I included the right dependency versions. Just because it compiles and the tests run doesn't mean it's formally correct.
          David Medinets made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Affects Version/s 1.5.0 [ 12318645 ]
          Assignee David Medinets [ medined ]
          David Medinets made changes -
          Link This issue is related to ACCUMULO-2446 [ ACCUMULO-2446 ]
          Hide
          Christopher Tubbs added a comment -

          A suggestion: use "org.apache:apache:14" as the parent pom, because it manages a lot of plugin dependency versions that would previously have been managed with by having the accumulo-examples as the parent pom. This helps ensure reproducible builds, and would be better than specifying the versions for the plugins explicitly here. (Kudos for adding the missing groupIds, though). The rest looks fine to me, provided they work.

          Show
          Christopher Tubbs added a comment - A suggestion: use "org.apache:apache:14" as the parent pom, because it manages a lot of plugin dependency versions that would previously have been managed with by having the accumulo-examples as the parent pom. This helps ensure reproducible builds, and would be better than specifying the versions for the plugins explicitly here. (Kudos for adding the missing groupIds, though). The rest looks fine to me, provided they work.
          Hide
          Mike Drob added a comment -
          <hadoop.version>1.0.4</hadoop.version>
          

          nit: everything else is of the form version.hadoop

          Show
          Mike Drob added a comment - <hadoop.version>1.0.4</hadoop.version> nit: everything else is of the form version.hadoop
          Hide
          David Medinets added a comment -

          I tried adding the following to the pom.xml file:

            <parent>
                <groupId>org.apache</groupId>
                <artifactId>apache</artifactId>
                <version>14</version>
            </parent>
          

          However, I now see a lot of error messages:

          [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project wikisearch-ingest: Compilation failure: Compilation failure:
          [ERROR] /Users/davidmedinets/NetBeansProjects/accumulo-wikisearch/ingest/src/main/java/org/apache/accumulo/examples/wikisearch/ingest/WikipediaInputFormat.java:[63,6] annotations are not supported in -source 1.4
          [ERROR] (use -source 5 or higher to enable annotations)
          

          Any ideas how to resolve this?

          Show
          David Medinets added a comment - I tried adding the following to the pom.xml file: <parent> <groupId>org.apache</groupId> <artifactId>apache</artifactId> <version>14</version> </parent> However, I now see a lot of error messages: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project wikisearch-ingest: Compilation failure: Compilation failure: [ERROR] /Users/davidmedinets/NetBeansProjects/accumulo-wikisearch/ingest/src/main/java/org/apache/accumulo/examples/wikisearch/ingest/WikipediaInputFormat.java:[63,6] annotations are not supported in -source 1.4 [ERROR] (use -source 5 or higher to enable annotations) Any ideas how to resolve this?
          Hide
          Josh Elser added a comment -

          David Medinets try http://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-source-and-target.html. You likely want to set this to 1.6 or 1.7, not sure what the target java version story is for wikisearch (probably 1.6)

          Show
          Josh Elser added a comment - David Medinets try http://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-source-and-target.html . You likely want to set this to 1.6 or 1.7, not sure what the target java version story is for wikisearch (probably 1.6)
          Hide
          David Medinets added a comment -
          • changed hadoop.version to version.hadoop
          • add compiler plugin set to 1.7 java
          • sorted properties by name
          Show
          David Medinets added a comment - changed hadoop.version to version.hadoop add compiler plugin set to 1.7 java sorted properties by name
          David Medinets made changes -
          Attachment accumulo-2779.patch [ 12643647 ]
          Hide
          Christopher Tubbs added a comment -

          You should drop the versions on the plugins whose versions are now managed by the parent POM.

          Also, I wonder how many of those dependencies are needed at the <compile> scope. (fate, for instance, is probably only needed at <runtime>), but that can be saved to a future action.

          Show
          Christopher Tubbs added a comment - You should drop the versions on the plugins whose versions are now managed by the parent POM. Also, I wonder how many of those dependencies are needed at the <compile> scope. (fate, for instance, is probably only needed at <runtime>), but that can be saved to a future action.

            People

            • Assignee:
              David Medinets
              Reporter:
              David Medinets
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:

                Development