Accumulo
  1. Accumulo
  2. ACCUMULO-2460

Experimental properties no longer hidden from DefaultConfiguration

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.0
    • Component/s: None
    • Labels:

      Description

      DefaultConfiguration now contains experimental properties, which exposes them prominently to users in the API and in other places, such as in the shell. Users may assume they are stable when they are so prominent. Experimental properties should be excluded from the default configuration (equivalent to default value of null).

        Issue Links

          Activity

          Christopher Tubbs created issue -
          Christopher Tubbs made changes -
          Field Original Value New Value
          Link This issue is broken by ACCUMULO-2401 [ ACCUMULO-2401 ]
          Hide
          Josh Elser added a comment -

          Raising priority: doesn't this represent an unintended change in functionality?

          Show
          Josh Elser added a comment - Raising priority: doesn't this represent an unintended change in functionality?
          Josh Elser made changes -
          Priority Major [ 3 ] Critical [ 2 ]
          Keith Turner made changes -
          Assignee Keith Turner [ kturner ]
          Keith Turner made changes -
          Remote Link This issue links to "review (Web Link)" [ 14579 ]
          Hide
          Keith Turner added a comment -

          Christopher Tubbs I created a patch to hide experimental props in the shell. Were you thinking of doing anything more?

          Show
          Keith Turner added a comment - Christopher Tubbs I created a patch to hide experimental props in the shell. Were you thinking of doing anything more?
          Hide
          Christopher Tubbs added a comment -

          I took at the patch and it looks fine. I guess whether it is sufficient or not depends on whether we consider the properties enumerated in DefaultConfiguration's iterator part of the public API.

          Show
          Christopher Tubbs added a comment - I took at the patch and it looks fine. I guess whether it is sufficient or not depends on whether we consider the properties enumerated in DefaultConfiguration's iterator part of the public API.
          Hide
          Sean Busbey added a comment -

          None of our published guidelines for the public api include o.a.a.core.conf.AccumuloConfiguration. So I wouldn't consider anything that comes out of it part of the public API.

          Show
          Sean Busbey added a comment - None of our published guidelines for the public api include o.a.a.core.conf.AccumuloConfiguration. So I wouldn't consider anything that comes out of it part of the public API.
          Hide
          Christopher Tubbs added a comment -

          Okay, then I think Keith's patch is probably sufficient, then.

          Show
          Christopher Tubbs added a comment - Okay, then I think Keith's patch is probably sufficient, then.
          Hide
          ASF subversion and git services added a comment -

          Commit 3ef67cbeea54f072c901f25f7bc17740cd30f981 in accumulo's branch refs/heads/1.6.0-SNAPSHOT from [~keith_turner]
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=3ef67cb ]

          ACCUMULO-2460 hide experimental props in shell

          Show
          ASF subversion and git services added a comment - Commit 3ef67cbeea54f072c901f25f7bc17740cd30f981 in accumulo's branch refs/heads/1.6.0-SNAPSHOT from [~keith_turner] [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=3ef67cb ] ACCUMULO-2460 hide experimental props in shell
          Hide
          ASF subversion and git services added a comment -

          Commit 3ef67cbeea54f072c901f25f7bc17740cd30f981 in accumulo's branch refs/heads/master from [~keith_turner]
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=3ef67cb ]

          ACCUMULO-2460 hide experimental props in shell

          Show
          ASF subversion and git services added a comment - Commit 3ef67cbeea54f072c901f25f7bc17740cd30f981 in accumulo's branch refs/heads/master from [~keith_turner] [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=3ef67cb ] ACCUMULO-2460 hide experimental props in shell
          Keith Turner made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          ASF subversion and git services added a comment -

          Commit 70d472662d5c21c4f571c9501457172745e59a4c in accumulo's branch refs/heads/1.6.0-SNAPSHOT from [~keith_turner]
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=70d4726 ]

          ACCUMULO-2460 removed empty javadoc

          Show
          ASF subversion and git services added a comment - Commit 70d472662d5c21c4f571c9501457172745e59a4c in accumulo's branch refs/heads/1.6.0-SNAPSHOT from [~keith_turner] [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=70d4726 ] ACCUMULO-2460 removed empty javadoc
          Hide
          ASF subversion and git services added a comment -

          Commit 70d472662d5c21c4f571c9501457172745e59a4c in accumulo's branch refs/heads/master from [~keith_turner]
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=70d4726 ]

          ACCUMULO-2460 removed empty javadoc

          Show
          ASF subversion and git services added a comment - Commit 70d472662d5c21c4f571c9501457172745e59a4c in accumulo's branch refs/heads/master from [~keith_turner] [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=70d4726 ] ACCUMULO-2460 removed empty javadoc

            People

            • Assignee:
              Keith Turner
              Reporter:
              Christopher Tubbs
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development