[ACCUMULO-2423] Converge Shell scripts on single implementation

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6.0
• Fix Version/s: 1.7.0
• Assignee: Mike Drob
• Reporter: Mike Drob
• Created: 28/Feb/14 17:40
• Updated: 11/May/15 18:09
• Resolved: 10/Jul/14 21:17

Description

Do we want to have a stated dependency on a particular shell? Most of our scripts explicitly use bash, but some use sh. Most scripts invoke #!/usr/bin/env bash but some do #!/bin/bash or other crazy things.

I don't have a particular preference which way we go, but I'd like to see us standardize one way or the other.

If we use /bin/sh, then we can run everything through the checkbashisms script (also available for other distros)

If we go the other way, and switch everything to bash, then we can run them through ksh -n for deprecation warnings. I know that's a different shell, but they're still moderately useful.

Issue Links

• breaks: ACCUMULO-3373 generate-thrift.sh never matches any thrift version
• breaks: ACCUMULO-3655 tool.sh erroneously complains about multiple zookeeper*.jar files in ZOOKEEPER_HOME
• breaks: ACCUMULO-2993 division by 0