Accumulo
  1. Accumulo
  2. ACCUMULO-2390

TraceProxy.trace should not throw InvocationTargetException

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.4, 1.5.0
    • Fix Version/s: 1.4.5, 1.5.1, 1.6.0
    • Component/s: trace
    • Labels:

      Description

      In TraceProxy.trace there is the following code snippet:

              try {
                return method.invoke(instance, args);
              } catch (Throwable ex) {
                ex.printStackTrace();
                throw ex;
              }
      

      When this is an InvocationTargetException, it can really mess with the calling code's exception handling logic.

        Issue Links

          Activity

          Hide
          ASF subversion and git services added a comment -

          Commit 2829426618b6e7d1487a4c88dd7b09186b9898d5 in accumulo's branch refs/heads/1.4.5-SNAPSHOT from Mike Drob
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=2829426 ]

          ACCUMULO-2390 InvocationTargetEx in TraceProxy

          Handle InvocationTargetException specifically in TraceProxy, instead
          of letting it get propogated up the call stack. In some cases this is
          very bad as it turned into an UndeclaredThrowableException and made
          debugging more difficult than necessary.

          Added unit test to verify behaviour.

          Show
          ASF subversion and git services added a comment - Commit 2829426618b6e7d1487a4c88dd7b09186b9898d5 in accumulo's branch refs/heads/1.4.5-SNAPSHOT from Mike Drob [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=2829426 ] ACCUMULO-2390 InvocationTargetEx in TraceProxy Handle InvocationTargetException specifically in TraceProxy, instead of letting it get propogated up the call stack. In some cases this is very bad as it turned into an UndeclaredThrowableException and made debugging more difficult than necessary. Added unit test to verify behaviour.
          Hide
          ASF subversion and git services added a comment -

          Commit 2829426618b6e7d1487a4c88dd7b09186b9898d5 in accumulo's branch refs/heads/1.5.1-SNAPSHOT from Mike Drob
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=2829426 ]

          ACCUMULO-2390 InvocationTargetEx in TraceProxy

          Handle InvocationTargetException specifically in TraceProxy, instead
          of letting it get propogated up the call stack. In some cases this is
          very bad as it turned into an UndeclaredThrowableException and made
          debugging more difficult than necessary.

          Added unit test to verify behaviour.

          Show
          ASF subversion and git services added a comment - Commit 2829426618b6e7d1487a4c88dd7b09186b9898d5 in accumulo's branch refs/heads/1.5.1-SNAPSHOT from Mike Drob [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=2829426 ] ACCUMULO-2390 InvocationTargetEx in TraceProxy Handle InvocationTargetException specifically in TraceProxy, instead of letting it get propogated up the call stack. In some cases this is very bad as it turned into an UndeclaredThrowableException and made debugging more difficult than necessary. Added unit test to verify behaviour.
          Hide
          ASF subversion and git services added a comment -

          Commit 2829426618b6e7d1487a4c88dd7b09186b9898d5 in accumulo's branch refs/heads/1.6.0-SNAPSHOT from Mike Drob
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=2829426 ]

          ACCUMULO-2390 InvocationTargetEx in TraceProxy

          Handle InvocationTargetException specifically in TraceProxy, instead
          of letting it get propogated up the call stack. In some cases this is
          very bad as it turned into an UndeclaredThrowableException and made
          debugging more difficult than necessary.

          Added unit test to verify behaviour.

          Show
          ASF subversion and git services added a comment - Commit 2829426618b6e7d1487a4c88dd7b09186b9898d5 in accumulo's branch refs/heads/1.6.0-SNAPSHOT from Mike Drob [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=2829426 ] ACCUMULO-2390 InvocationTargetEx in TraceProxy Handle InvocationTargetException specifically in TraceProxy, instead of letting it get propogated up the call stack. In some cases this is very bad as it turned into an UndeclaredThrowableException and made debugging more difficult than necessary. Added unit test to verify behaviour.
          Hide
          ASF subversion and git services added a comment -

          Commit 2829426618b6e7d1487a4c88dd7b09186b9898d5 in accumulo's branch refs/heads/master from Mike Drob
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=2829426 ]

          ACCUMULO-2390 InvocationTargetEx in TraceProxy

          Handle InvocationTargetException specifically in TraceProxy, instead
          of letting it get propogated up the call stack. In some cases this is
          very bad as it turned into an UndeclaredThrowableException and made
          debugging more difficult than necessary.

          Added unit test to verify behaviour.

          Show
          ASF subversion and git services added a comment - Commit 2829426618b6e7d1487a4c88dd7b09186b9898d5 in accumulo's branch refs/heads/master from Mike Drob [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=2829426 ] ACCUMULO-2390 InvocationTargetEx in TraceProxy Handle InvocationTargetException specifically in TraceProxy, instead of letting it get propogated up the call stack. In some cases this is very bad as it turned into an UndeclaredThrowableException and made debugging more difficult than necessary. Added unit test to verify behaviour.

            People

            • Assignee:
              Mike Drob
              Reporter:
              Mike Drob
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development