Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.7.0
    • Component/s: docs

      Description

      Author javadoc for org.apache.accumulo.core.conf classes.

        Issue Links

          Activity

          Bill Havanki created issue -
          Bill Havanki made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          Bill Havanki made changes -
          Remote Link This issue links to "Review (Web Link)" [ 13452 ]
          Hide
          Bill Havanki added a comment -

          Review available.

          Show
          Bill Havanki added a comment - Review available.
          Bill Havanki made changes -
          Attachment ACCUMULO-1974.patch [ 12617831 ]
          Hide
          Bill Havanki added a comment -

          Patch is against master.

          Show
          Bill Havanki added a comment - Patch is against master.
          Bill Havanki made changes -
          Status In Progress [ 3 ] Patch Available [ 10002 ]
          Josh Elser made changes -
          Fix Version/s 1.7.0 [ 12324607 ]
          Hide
          Josh Elser added a comment -

          Bill Havanki, do you have the capabilities to rebase these changes on master easily? I'm getting failures in applying the patch:

          error: patch failed: core/src/main/java/org/apache/accumulo/core/conf/Property.java:600
          error: core/src/main/java/org/apache/accumulo/core/conf/Property.java: patch does not apply
          
          Show
          Josh Elser added a comment - Bill Havanki , do you have the capabilities to rebase these changes on master easily? I'm getting failures in applying the patch: error: patch failed: core/src/main/java/org/apache/accumulo/core/conf/Property.java:600 error: core/src/main/java/org/apache/accumulo/core/conf/Property.java: patch does not apply
          Hide
          Bill Havanki added a comment -

          Here's a rebased patch for master.

          Show
          Bill Havanki added a comment - Here's a rebased patch for master.
          Bill Havanki made changes -
          Attachment ACCUMULO-1974.master.patch [ 12618946 ]
          Hide
          Bill Havanki added a comment -

          I should note that, for me, Git fell back to a 3-way merge when I rebased. The merged Property.java file looks OK to me.

          Show
          Bill Havanki added a comment - I should note that, for me, Git fell back to a 3-way merge when I rebased. The merged Property.java file looks OK to me.
          Bill Havanki made changes -
          Attachment ACCUMULO-1974.patch [ 12617831 ]
          Hide
          ASF subversion and git services added a comment -

          Commit 3a2e0a925002a2cb8e408791a7f0d2a0fa2f4c96 in branch refs/heads/master from Bill Havanki
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=3a2e0a9 ]

          ACCUMULO-1974 Javadoc for core/conf.

          Signed-off-by: Josh Elser <elserj@apache.org>

          Show
          ASF subversion and git services added a comment - Commit 3a2e0a925002a2cb8e408791a7f0d2a0fa2f4c96 in branch refs/heads/master from Bill Havanki [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=3a2e0a9 ] ACCUMULO-1974 Javadoc for core/conf. Signed-off-by: Josh Elser <elserj@apache.org>
          Hide
          Josh Elser added a comment -

          Applied!

          Show
          Josh Elser added a comment - Applied!
          Josh Elser made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Christopher Tubbs made changes -
          Fix Version/s 1.6.0 [ 12322468 ]
          Fix Version/s 1.7.0 [ 12324607 ]
          Christopher Tubbs made changes -
          Fix Version/s 1.7.0 [ 12324607 ]
          Fix Version/s 1.6.0 [ 12322468 ]
          Hide
          ASF subversion and git services added a comment -

          Commit dcc19ccbada8c2f0a206ec797455294015e8ca6d in accumulo's branch refs/heads/master from Christopher Tubbs
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=dcc19cc ]

          ACCUMULO-1961 Re-apply inadvertently dropped 4abb3f1 to master branch

          Fixes trivial warnings and broken javadocs which have been recently
          introduced. Specifically, removes references to private and
          package-private (default) classes in public javadoc comments (internal
          details aren't relevant to the API and subject to change). Another
          common warning was unused imports and javadoc param tags that refer to
          non-existent parameters.

          Commits against the following JIRA issues introduced these:
          ACCUMULO-1948, ACCUMULO-1974, ACCUMULO-2021, ACCUMULO-2136,
          ACCUMULO-2322, ACCUMULO-2334, ACCUMULO-2350

          Show
          ASF subversion and git services added a comment - Commit dcc19ccbada8c2f0a206ec797455294015e8ca6d in accumulo's branch refs/heads/master from Christopher Tubbs [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=dcc19cc ] ACCUMULO-1961 Re-apply inadvertently dropped 4abb3f1 to master branch Fixes trivial warnings and broken javadocs which have been recently introduced. Specifically, removes references to private and package-private (default) classes in public javadoc comments (internal details aren't relevant to the API and subject to change). Another common warning was unused imports and javadoc param tags that refer to non-existent parameters. Commits against the following JIRA issues introduced these: ACCUMULO-1948 , ACCUMULO-1974 , ACCUMULO-2021 , ACCUMULO-2136 , ACCUMULO-2322 , ACCUMULO-2334 , ACCUMULO-2350
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open In Progress In Progress
          59m 16s 1 Bill Havanki 06/Dec/13 19:24
          In Progress In Progress Patch Available Patch Available
          2d 18h 32m 1 Bill Havanki 09/Dec/13 13:57
          Patch Available Patch Available Resolved Resolved
          7d 5h 29m 1 Josh Elser 16/Dec/13 19:27

            People

            • Assignee:
              Bill Havanki
              Reporter:
              Bill Havanki
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development