Accumulo
  1. Accumulo
  2. ACCUMULO-1854

AccumuloInputFormat can be less strict about contents of Configuration

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.4, 1.5.0
    • Fix Version/s: 1.4.5, 1.5.1, 1.6.0
    • Component/s: None
    • Labels:
      None

      Description

      The AccumuloInputFormat required that the same exact Configuration object which was provided to its static configuration methods is also provided to its getSplits() and createRecordReader() methods.

      In practice, some tools, like MultipleInputs or Pig, don't guarantee that the same Configuration object is provided to getSplits() and createRecordReader(). This tends to be a common method of interaction to ensure that multiple InputFormats don't collide with one another in the same Configuration object (e.g. FileInputFormat). By serialization the necessary information from the Configuration regarding how to query Accumulo into the InputSplit AccumuloInputFormat creates, we can alleviate this requirement and make client interaction a little more standard.

        Issue Links

          Activity

          Hide
          ASF subversion and git services added a comment -

          Commit f8e14c794992bd5d8d530b50338b16436088c243 in branch refs/heads/1.6.0-SNAPSHOT from Christopher Tubbs
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=f8e14c7 ]

          ACCUMULO-1854 Remove compiler warnings

          Show
          ASF subversion and git services added a comment - Commit f8e14c794992bd5d8d530b50338b16436088c243 in branch refs/heads/1.6.0-SNAPSHOT from Christopher Tubbs [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=f8e14c7 ] ACCUMULO-1854 Remove compiler warnings
          Hide
          Josh Elser added a comment -

          Felt the need to update the title and description to better match what was actually done and be a little less misleading.

          Show
          Josh Elser added a comment - Felt the need to update the title and description to better match what was actually done and be a little less misleading.
          Hide
          ASF subversion and git services added a comment -

          Commit e6e1df41abad9291b919b675147e211ad7cc8cef in branch refs/heads/master from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=e6e1df4 ]

          ACCUMULO-1854 More missing licenses

          Show
          ASF subversion and git services added a comment - Commit e6e1df41abad9291b919b675147e211ad7cc8cef in branch refs/heads/master from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=e6e1df4 ] ACCUMULO-1854 More missing licenses
          Hide
          ASF subversion and git services added a comment -

          Commit c88d87aa08819ed94fa9aae8583985b4fcf8e588 in branch refs/heads/master from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=c88d87a ]

          ACCUMULO-1854 Update tests for hadoop-2 compatibility

          Show
          ASF subversion and git services added a comment - Commit c88d87aa08819ed94fa9aae8583985b4fcf8e588 in branch refs/heads/master from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=c88d87a ] ACCUMULO-1854 Update tests for hadoop-2 compatibility
          Hide
          ASF subversion and git services added a comment -

          Commit e6e1df41abad9291b919b675147e211ad7cc8cef in branch refs/heads/1.6.0-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=e6e1df4 ]

          ACCUMULO-1854 More missing licenses

          Show
          ASF subversion and git services added a comment - Commit e6e1df41abad9291b919b675147e211ad7cc8cef in branch refs/heads/1.6.0-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=e6e1df4 ] ACCUMULO-1854 More missing licenses
          Hide
          ASF subversion and git services added a comment -

          Commit c88d87aa08819ed94fa9aae8583985b4fcf8e588 in branch refs/heads/1.6.0-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=c88d87a ]

          ACCUMULO-1854 Update tests for hadoop-2 compatibility

          Show
          ASF subversion and git services added a comment - Commit c88d87aa08819ed94fa9aae8583985b4fcf8e588 in branch refs/heads/1.6.0-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=c88d87a ] ACCUMULO-1854 Update tests for hadoop-2 compatibility
          Hide
          ASF subversion and git services added a comment -

          Commit e6e1df41abad9291b919b675147e211ad7cc8cef in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=e6e1df4 ]

          ACCUMULO-1854 More missing licenses

          Show
          ASF subversion and git services added a comment - Commit e6e1df41abad9291b919b675147e211ad7cc8cef in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=e6e1df4 ] ACCUMULO-1854 More missing licenses
          Hide
          ASF subversion and git services added a comment -

          Commit c88d87aa08819ed94fa9aae8583985b4fcf8e588 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=c88d87a ]

          ACCUMULO-1854 Update tests for hadoop-2 compatibility

          Show
          ASF subversion and git services added a comment - Commit c88d87aa08819ed94fa9aae8583985b4fcf8e588 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=c88d87a ] ACCUMULO-1854 Update tests for hadoop-2 compatibility
          Hide
          ASF subversion and git services added a comment -

          Commit 6caa1597231bddc806fa2e8f4be596fc1e95e949 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=6caa159 ]

          ACCUMULO-1854 Add in missing license.

          Show
          ASF subversion and git services added a comment - Commit 6caa1597231bddc806fa2e8f4be596fc1e95e949 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=6caa159 ] ACCUMULO-1854 Add in missing license.
          Hide
          ASF subversion and git services added a comment -

          Commit 6caa1597231bddc806fa2e8f4be596fc1e95e949 in branch refs/heads/1.4.5-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=6caa159 ]

          ACCUMULO-1854 Add in missing license.

          Show
          ASF subversion and git services added a comment - Commit 6caa1597231bddc806fa2e8f4be596fc1e95e949 in branch refs/heads/1.4.5-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=6caa159 ] ACCUMULO-1854 Add in missing license.
          Hide
          ASF subversion and git services added a comment -

          Commit 3a703d75d0bc37ad7aceb7357f1a69b67b7216d4 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=3a703d7 ]

          Merge branch '1.4.5-SNAPSHOT' into ACCUMULO-1854-1.5-merge

          Conflicts:
          core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloInputFormat.java
          server/src/main/java/org/apache/accumulo/server/util/MetadataTable.java
          src/core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java
          src/core/src/test/java/org/apache/accumulo/core/client/mapreduce/AccumuloInputFormatTest.java
          src/core/src/test/java/org/apache/accumulo/core/client/mapreduce/AccumuloRowInputFormatTest.java
          src/examples/simple/src/test/java/org/apache/accumulo/examples/simple/filedata/ChunkInputFormatTest.java

          Show
          ASF subversion and git services added a comment - Commit 3a703d75d0bc37ad7aceb7357f1a69b67b7216d4 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=3a703d7 ] Merge branch '1.4.5-SNAPSHOT' into ACCUMULO-1854 -1.5-merge Conflicts: core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloInputFormat.java server/src/main/java/org/apache/accumulo/server/util/MetadataTable.java src/core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java src/core/src/test/java/org/apache/accumulo/core/client/mapreduce/AccumuloInputFormatTest.java src/core/src/test/java/org/apache/accumulo/core/client/mapreduce/AccumuloRowInputFormatTest.java src/examples/simple/src/test/java/org/apache/accumulo/examples/simple/filedata/ChunkInputFormatTest.java
          Hide
          ASF subversion and git services added a comment -

          Commit e1dd6f9b28fa579eada4334b7072fca4155add15 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=e1dd6f9 ]

          ACCUMULO-1854 Remove todo and finish toString

          Show
          ASF subversion and git services added a comment - Commit e1dd6f9b28fa579eada4334b7072fca4155add15 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=e1dd6f9 ] ACCUMULO-1854 Remove todo and finish toString
          Hide
          ASF subversion and git services added a comment -

          Commit 8dd3ae4b1d614182f26d382d3d16956726d26702 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=8dd3ae4 ]

          ACCUMULO-1854 Remove unnecessary arguments from methods

          Show
          ASF subversion and git services added a comment - Commit 8dd3ae4b1d614182f26d382d3d16956726d26702 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=8dd3ae4 ] ACCUMULO-1854 Remove unnecessary arguments from methods
          Hide
          ASF subversion and git services added a comment -

          Commit 73114819e85714f56838e2bcf16bf9b5c6c6a397 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7311481 ]

          Squashed commit of the following:

          commit dfbe098fb650d1d1605ac28ff0b195e229ecb345
          Author: Josh Elser <elserj@apache.org>
          Date: Wed Nov 20 23:57:18 2013 -0500

          ACCUMULO-1843 Add in log4j Level to RangeInputSplit. Add more tests, notably ones that exercise delegation of the input
          split to the Configuration.

          commit 38fdee9916edd938bea1642de5d4e5cf54a81596
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 17:47:57 2013 -0500

          ACCUMULO-1854 Fix up InputFormatBase to use the information stored on
          RangeInputSplit and fall back onto the Configuration.

          commit 0e6d1aba7eacef357e0a17c67a453dd5b50a49dc
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 16:23:49 2013 -0500

          ACCUMULO-1854 Clean up constructors. Add a test.

          commit 2f59f81f6e75f8a90ccfe3df00c6ad3f69174e0c
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 15:46:39 2013 -0500

          ACCUMULO-1854 Move RangeInputSplit into its own file and store all
          connection information into it.

          Show
          ASF subversion and git services added a comment - Commit 73114819e85714f56838e2bcf16bf9b5c6c6a397 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7311481 ] Squashed commit of the following: commit dfbe098fb650d1d1605ac28ff0b195e229ecb345 Author: Josh Elser <elserj@apache.org> Date: Wed Nov 20 23:57:18 2013 -0500 ACCUMULO-1843 Add in log4j Level to RangeInputSplit. Add more tests, notably ones that exercise delegation of the input split to the Configuration. commit 38fdee9916edd938bea1642de5d4e5cf54a81596 Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 17:47:57 2013 -0500 ACCUMULO-1854 Fix up InputFormatBase to use the information stored on RangeInputSplit and fall back onto the Configuration. commit 0e6d1aba7eacef357e0a17c67a453dd5b50a49dc Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 16:23:49 2013 -0500 ACCUMULO-1854 Clean up constructors. Add a test. commit 2f59f81f6e75f8a90ccfe3df00c6ad3f69174e0c Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 15:46:39 2013 -0500 ACCUMULO-1854 Move RangeInputSplit into its own file and store all connection information into it.
          Hide
          ASF subversion and git services added a comment -

          Commit 73114819e85714f56838e2bcf16bf9b5c6c6a397 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7311481 ]

          Squashed commit of the following:

          commit dfbe098fb650d1d1605ac28ff0b195e229ecb345
          Author: Josh Elser <elserj@apache.org>
          Date: Wed Nov 20 23:57:18 2013 -0500

          ACCUMULO-1843 Add in log4j Level to RangeInputSplit. Add more tests, notably ones that exercise delegation of the input
          split to the Configuration.

          commit 38fdee9916edd938bea1642de5d4e5cf54a81596
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 17:47:57 2013 -0500

          ACCUMULO-1854 Fix up InputFormatBase to use the information stored on
          RangeInputSplit and fall back onto the Configuration.

          commit 0e6d1aba7eacef357e0a17c67a453dd5b50a49dc
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 16:23:49 2013 -0500

          ACCUMULO-1854 Clean up constructors. Add a test.

          commit 2f59f81f6e75f8a90ccfe3df00c6ad3f69174e0c
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 15:46:39 2013 -0500

          ACCUMULO-1854 Move RangeInputSplit into its own file and store all
          connection information into it.

          Show
          ASF subversion and git services added a comment - Commit 73114819e85714f56838e2bcf16bf9b5c6c6a397 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7311481 ] Squashed commit of the following: commit dfbe098fb650d1d1605ac28ff0b195e229ecb345 Author: Josh Elser <elserj@apache.org> Date: Wed Nov 20 23:57:18 2013 -0500 ACCUMULO-1843 Add in log4j Level to RangeInputSplit. Add more tests, notably ones that exercise delegation of the input split to the Configuration. commit 38fdee9916edd938bea1642de5d4e5cf54a81596 Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 17:47:57 2013 -0500 ACCUMULO-1854 Fix up InputFormatBase to use the information stored on RangeInputSplit and fall back onto the Configuration. commit 0e6d1aba7eacef357e0a17c67a453dd5b50a49dc Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 16:23:49 2013 -0500 ACCUMULO-1854 Clean up constructors. Add a test. commit 2f59f81f6e75f8a90ccfe3df00c6ad3f69174e0c Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 15:46:39 2013 -0500 ACCUMULO-1854 Move RangeInputSplit into its own file and store all connection information into it.
          Hide
          ASF subversion and git services added a comment -

          Commit 73114819e85714f56838e2bcf16bf9b5c6c6a397 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7311481 ]

          Squashed commit of the following:

          commit dfbe098fb650d1d1605ac28ff0b195e229ecb345
          Author: Josh Elser <elserj@apache.org>
          Date: Wed Nov 20 23:57:18 2013 -0500

          ACCUMULO-1843 Add in log4j Level to RangeInputSplit. Add more tests, notably ones that exercise delegation of the input
          split to the Configuration.

          commit 38fdee9916edd938bea1642de5d4e5cf54a81596
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 17:47:57 2013 -0500

          ACCUMULO-1854 Fix up InputFormatBase to use the information stored on
          RangeInputSplit and fall back onto the Configuration.

          commit 0e6d1aba7eacef357e0a17c67a453dd5b50a49dc
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 16:23:49 2013 -0500

          ACCUMULO-1854 Clean up constructors. Add a test.

          commit 2f59f81f6e75f8a90ccfe3df00c6ad3f69174e0c
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 15:46:39 2013 -0500

          ACCUMULO-1854 Move RangeInputSplit into its own file and store all
          connection information into it.

          Show
          ASF subversion and git services added a comment - Commit 73114819e85714f56838e2bcf16bf9b5c6c6a397 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7311481 ] Squashed commit of the following: commit dfbe098fb650d1d1605ac28ff0b195e229ecb345 Author: Josh Elser <elserj@apache.org> Date: Wed Nov 20 23:57:18 2013 -0500 ACCUMULO-1843 Add in log4j Level to RangeInputSplit. Add more tests, notably ones that exercise delegation of the input split to the Configuration. commit 38fdee9916edd938bea1642de5d4e5cf54a81596 Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 17:47:57 2013 -0500 ACCUMULO-1854 Fix up InputFormatBase to use the information stored on RangeInputSplit and fall back onto the Configuration. commit 0e6d1aba7eacef357e0a17c67a453dd5b50a49dc Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 16:23:49 2013 -0500 ACCUMULO-1854 Clean up constructors. Add a test. commit 2f59f81f6e75f8a90ccfe3df00c6ad3f69174e0c Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 15:46:39 2013 -0500 ACCUMULO-1854 Move RangeInputSplit into its own file and store all connection information into it.
          Hide
          ASF subversion and git services added a comment -

          Commit 67189202183342888dc9b00b5ef3366e748997d6 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=6718920 ]

          ACCUMULO-1854 Merge the mapred and mapreduce RangeInputSplits into one class

          Show
          ASF subversion and git services added a comment - Commit 67189202183342888dc9b00b5ef3366e748997d6 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=6718920 ] ACCUMULO-1854 Merge the mapred and mapreduce RangeInputSplits into one class
          Hide
          ASF subversion and git services added a comment -

          Commit e1dd6f9b28fa579eada4334b7072fca4155add15 in branch refs/heads/1.4.5-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=e1dd6f9 ]

          ACCUMULO-1854 Remove todo and finish toString

          Show
          ASF subversion and git services added a comment - Commit e1dd6f9b28fa579eada4334b7072fca4155add15 in branch refs/heads/1.4.5-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=e1dd6f9 ] ACCUMULO-1854 Remove todo and finish toString
          Hide
          ASF subversion and git services added a comment -

          Commit 8dd3ae4b1d614182f26d382d3d16956726d26702 in branch refs/heads/1.4.5-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=8dd3ae4 ]

          ACCUMULO-1854 Remove unnecessary arguments from methods

          Show
          ASF subversion and git services added a comment - Commit 8dd3ae4b1d614182f26d382d3d16956726d26702 in branch refs/heads/1.4.5-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=8dd3ae4 ] ACCUMULO-1854 Remove unnecessary arguments from methods
          Hide
          ASF subversion and git services added a comment -

          Commit 73114819e85714f56838e2bcf16bf9b5c6c6a397 in branch refs/heads/1.4.5-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7311481 ]

          Squashed commit of the following:

          commit dfbe098fb650d1d1605ac28ff0b195e229ecb345
          Author: Josh Elser <elserj@apache.org>
          Date: Wed Nov 20 23:57:18 2013 -0500

          ACCUMULO-1843 Add in log4j Level to RangeInputSplit. Add more tests, notably ones that exercise delegation of the input
          split to the Configuration.

          commit 38fdee9916edd938bea1642de5d4e5cf54a81596
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 17:47:57 2013 -0500

          ACCUMULO-1854 Fix up InputFormatBase to use the information stored on
          RangeInputSplit and fall back onto the Configuration.

          commit 0e6d1aba7eacef357e0a17c67a453dd5b50a49dc
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 16:23:49 2013 -0500

          ACCUMULO-1854 Clean up constructors. Add a test.

          commit 2f59f81f6e75f8a90ccfe3df00c6ad3f69174e0c
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 15:46:39 2013 -0500

          ACCUMULO-1854 Move RangeInputSplit into its own file and store all
          connection information into it.

          Show
          ASF subversion and git services added a comment - Commit 73114819e85714f56838e2bcf16bf9b5c6c6a397 in branch refs/heads/1.4.5-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7311481 ] Squashed commit of the following: commit dfbe098fb650d1d1605ac28ff0b195e229ecb345 Author: Josh Elser <elserj@apache.org> Date: Wed Nov 20 23:57:18 2013 -0500 ACCUMULO-1843 Add in log4j Level to RangeInputSplit. Add more tests, notably ones that exercise delegation of the input split to the Configuration. commit 38fdee9916edd938bea1642de5d4e5cf54a81596 Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 17:47:57 2013 -0500 ACCUMULO-1854 Fix up InputFormatBase to use the information stored on RangeInputSplit and fall back onto the Configuration. commit 0e6d1aba7eacef357e0a17c67a453dd5b50a49dc Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 16:23:49 2013 -0500 ACCUMULO-1854 Clean up constructors. Add a test. commit 2f59f81f6e75f8a90ccfe3df00c6ad3f69174e0c Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 15:46:39 2013 -0500 ACCUMULO-1854 Move RangeInputSplit into its own file and store all connection information into it.
          Hide
          ASF subversion and git services added a comment -

          Commit 73114819e85714f56838e2bcf16bf9b5c6c6a397 in branch refs/heads/1.4.5-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7311481 ]

          Squashed commit of the following:

          commit dfbe098fb650d1d1605ac28ff0b195e229ecb345
          Author: Josh Elser <elserj@apache.org>
          Date: Wed Nov 20 23:57:18 2013 -0500

          ACCUMULO-1843 Add in log4j Level to RangeInputSplit. Add more tests, notably ones that exercise delegation of the input
          split to the Configuration.

          commit 38fdee9916edd938bea1642de5d4e5cf54a81596
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 17:47:57 2013 -0500

          ACCUMULO-1854 Fix up InputFormatBase to use the information stored on
          RangeInputSplit and fall back onto the Configuration.

          commit 0e6d1aba7eacef357e0a17c67a453dd5b50a49dc
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 16:23:49 2013 -0500

          ACCUMULO-1854 Clean up constructors. Add a test.

          commit 2f59f81f6e75f8a90ccfe3df00c6ad3f69174e0c
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 15:46:39 2013 -0500

          ACCUMULO-1854 Move RangeInputSplit into its own file and store all
          connection information into it.

          Show
          ASF subversion and git services added a comment - Commit 73114819e85714f56838e2bcf16bf9b5c6c6a397 in branch refs/heads/1.4.5-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7311481 ] Squashed commit of the following: commit dfbe098fb650d1d1605ac28ff0b195e229ecb345 Author: Josh Elser <elserj@apache.org> Date: Wed Nov 20 23:57:18 2013 -0500 ACCUMULO-1843 Add in log4j Level to RangeInputSplit. Add more tests, notably ones that exercise delegation of the input split to the Configuration. commit 38fdee9916edd938bea1642de5d4e5cf54a81596 Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 17:47:57 2013 -0500 ACCUMULO-1854 Fix up InputFormatBase to use the information stored on RangeInputSplit and fall back onto the Configuration. commit 0e6d1aba7eacef357e0a17c67a453dd5b50a49dc Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 16:23:49 2013 -0500 ACCUMULO-1854 Clean up constructors. Add a test. commit 2f59f81f6e75f8a90ccfe3df00c6ad3f69174e0c Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 15:46:39 2013 -0500 ACCUMULO-1854 Move RangeInputSplit into its own file and store all connection information into it.
          Hide
          ASF subversion and git services added a comment -

          Commit 73114819e85714f56838e2bcf16bf9b5c6c6a397 in branch refs/heads/1.4.5-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7311481 ]

          Squashed commit of the following:

          commit dfbe098fb650d1d1605ac28ff0b195e229ecb345
          Author: Josh Elser <elserj@apache.org>
          Date: Wed Nov 20 23:57:18 2013 -0500

          ACCUMULO-1843 Add in log4j Level to RangeInputSplit. Add more tests, notably ones that exercise delegation of the input
          split to the Configuration.

          commit 38fdee9916edd938bea1642de5d4e5cf54a81596
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 17:47:57 2013 -0500

          ACCUMULO-1854 Fix up InputFormatBase to use the information stored on
          RangeInputSplit and fall back onto the Configuration.

          commit 0e6d1aba7eacef357e0a17c67a453dd5b50a49dc
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 16:23:49 2013 -0500

          ACCUMULO-1854 Clean up constructors. Add a test.

          commit 2f59f81f6e75f8a90ccfe3df00c6ad3f69174e0c
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 15:46:39 2013 -0500

          ACCUMULO-1854 Move RangeInputSplit into its own file and store all
          connection information into it.

          Show
          ASF subversion and git services added a comment - Commit 73114819e85714f56838e2bcf16bf9b5c6c6a397 in branch refs/heads/1.4.5-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7311481 ] Squashed commit of the following: commit dfbe098fb650d1d1605ac28ff0b195e229ecb345 Author: Josh Elser <elserj@apache.org> Date: Wed Nov 20 23:57:18 2013 -0500 ACCUMULO-1843 Add in log4j Level to RangeInputSplit. Add more tests, notably ones that exercise delegation of the input split to the Configuration. commit 38fdee9916edd938bea1642de5d4e5cf54a81596 Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 17:47:57 2013 -0500 ACCUMULO-1854 Fix up InputFormatBase to use the information stored on RangeInputSplit and fall back onto the Configuration. commit 0e6d1aba7eacef357e0a17c67a453dd5b50a49dc Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 16:23:49 2013 -0500 ACCUMULO-1854 Clean up constructors. Add a test. commit 2f59f81f6e75f8a90ccfe3df00c6ad3f69174e0c Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 15:46:39 2013 -0500 ACCUMULO-1854 Move RangeInputSplit into its own file and store all connection information into it.
          Hide
          ASF subversion and git services added a comment -

          Commit e1dd6f9b28fa579eada4334b7072fca4155add15 in branch refs/heads/ACCUMULO-1854-merge from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=e1dd6f9 ]

          ACCUMULO-1854 Remove todo and finish toString

          Show
          ASF subversion and git services added a comment - Commit e1dd6f9b28fa579eada4334b7072fca4155add15 in branch refs/heads/ ACCUMULO-1854 -merge from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=e1dd6f9 ] ACCUMULO-1854 Remove todo and finish toString
          Hide
          ASF subversion and git services added a comment -

          Commit 8dd3ae4b1d614182f26d382d3d16956726d26702 in branch refs/heads/ACCUMULO-1854-merge from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=8dd3ae4 ]

          ACCUMULO-1854 Remove unnecessary arguments from methods

          Show
          ASF subversion and git services added a comment - Commit 8dd3ae4b1d614182f26d382d3d16956726d26702 in branch refs/heads/ ACCUMULO-1854 -merge from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=8dd3ae4 ] ACCUMULO-1854 Remove unnecessary arguments from methods
          Hide
          ASF subversion and git services added a comment -

          Commit 73114819e85714f56838e2bcf16bf9b5c6c6a397 in branch refs/heads/ACCUMULO-1854-merge from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7311481 ]

          Squashed commit of the following:

          commit dfbe098fb650d1d1605ac28ff0b195e229ecb345
          Author: Josh Elser <elserj@apache.org>
          Date: Wed Nov 20 23:57:18 2013 -0500

          ACCUMULO-1843 Add in log4j Level to RangeInputSplit. Add more tests, notably ones that exercise delegation of the input
          split to the Configuration.

          commit 38fdee9916edd938bea1642de5d4e5cf54a81596
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 17:47:57 2013 -0500

          ACCUMULO-1854 Fix up InputFormatBase to use the information stored on
          RangeInputSplit and fall back onto the Configuration.

          commit 0e6d1aba7eacef357e0a17c67a453dd5b50a49dc
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 16:23:49 2013 -0500

          ACCUMULO-1854 Clean up constructors. Add a test.

          commit 2f59f81f6e75f8a90ccfe3df00c6ad3f69174e0c
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 15:46:39 2013 -0500

          ACCUMULO-1854 Move RangeInputSplit into its own file and store all
          connection information into it.

          Show
          ASF subversion and git services added a comment - Commit 73114819e85714f56838e2bcf16bf9b5c6c6a397 in branch refs/heads/ ACCUMULO-1854 -merge from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7311481 ] Squashed commit of the following: commit dfbe098fb650d1d1605ac28ff0b195e229ecb345 Author: Josh Elser <elserj@apache.org> Date: Wed Nov 20 23:57:18 2013 -0500 ACCUMULO-1843 Add in log4j Level to RangeInputSplit. Add more tests, notably ones that exercise delegation of the input split to the Configuration. commit 38fdee9916edd938bea1642de5d4e5cf54a81596 Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 17:47:57 2013 -0500 ACCUMULO-1854 Fix up InputFormatBase to use the information stored on RangeInputSplit and fall back onto the Configuration. commit 0e6d1aba7eacef357e0a17c67a453dd5b50a49dc Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 16:23:49 2013 -0500 ACCUMULO-1854 Clean up constructors. Add a test. commit 2f59f81f6e75f8a90ccfe3df00c6ad3f69174e0c Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 15:46:39 2013 -0500 ACCUMULO-1854 Move RangeInputSplit into its own file and store all connection information into it.
          Hide
          ASF subversion and git services added a comment -

          Commit 73114819e85714f56838e2bcf16bf9b5c6c6a397 in branch refs/heads/ACCUMULO-1854-merge from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7311481 ]

          Squashed commit of the following:

          commit dfbe098fb650d1d1605ac28ff0b195e229ecb345
          Author: Josh Elser <elserj@apache.org>
          Date: Wed Nov 20 23:57:18 2013 -0500

          ACCUMULO-1843 Add in log4j Level to RangeInputSplit. Add more tests, notably ones that exercise delegation of the input
          split to the Configuration.

          commit 38fdee9916edd938bea1642de5d4e5cf54a81596
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 17:47:57 2013 -0500

          ACCUMULO-1854 Fix up InputFormatBase to use the information stored on
          RangeInputSplit and fall back onto the Configuration.

          commit 0e6d1aba7eacef357e0a17c67a453dd5b50a49dc
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 16:23:49 2013 -0500

          ACCUMULO-1854 Clean up constructors. Add a test.

          commit 2f59f81f6e75f8a90ccfe3df00c6ad3f69174e0c
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 15:46:39 2013 -0500

          ACCUMULO-1854 Move RangeInputSplit into its own file and store all
          connection information into it.

          Show
          ASF subversion and git services added a comment - Commit 73114819e85714f56838e2bcf16bf9b5c6c6a397 in branch refs/heads/ ACCUMULO-1854 -merge from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7311481 ] Squashed commit of the following: commit dfbe098fb650d1d1605ac28ff0b195e229ecb345 Author: Josh Elser <elserj@apache.org> Date: Wed Nov 20 23:57:18 2013 -0500 ACCUMULO-1843 Add in log4j Level to RangeInputSplit. Add more tests, notably ones that exercise delegation of the input split to the Configuration. commit 38fdee9916edd938bea1642de5d4e5cf54a81596 Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 17:47:57 2013 -0500 ACCUMULO-1854 Fix up InputFormatBase to use the information stored on RangeInputSplit and fall back onto the Configuration. commit 0e6d1aba7eacef357e0a17c67a453dd5b50a49dc Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 16:23:49 2013 -0500 ACCUMULO-1854 Clean up constructors. Add a test. commit 2f59f81f6e75f8a90ccfe3df00c6ad3f69174e0c Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 15:46:39 2013 -0500 ACCUMULO-1854 Move RangeInputSplit into its own file and store all connection information into it.
          Hide
          ASF subversion and git services added a comment -

          Commit 73114819e85714f56838e2bcf16bf9b5c6c6a397 in branch refs/heads/ACCUMULO-1854-merge from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7311481 ]

          Squashed commit of the following:

          commit dfbe098fb650d1d1605ac28ff0b195e229ecb345
          Author: Josh Elser <elserj@apache.org>
          Date: Wed Nov 20 23:57:18 2013 -0500

          ACCUMULO-1843 Add in log4j Level to RangeInputSplit. Add more tests, notably ones that exercise delegation of the input
          split to the Configuration.

          commit 38fdee9916edd938bea1642de5d4e5cf54a81596
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 17:47:57 2013 -0500

          ACCUMULO-1854 Fix up InputFormatBase to use the information stored on
          RangeInputSplit and fall back onto the Configuration.

          commit 0e6d1aba7eacef357e0a17c67a453dd5b50a49dc
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 16:23:49 2013 -0500

          ACCUMULO-1854 Clean up constructors. Add a test.

          commit 2f59f81f6e75f8a90ccfe3df00c6ad3f69174e0c
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 15:46:39 2013 -0500

          ACCUMULO-1854 Move RangeInputSplit into its own file and store all
          connection information into it.

          Show
          ASF subversion and git services added a comment - Commit 73114819e85714f56838e2bcf16bf9b5c6c6a397 in branch refs/heads/ ACCUMULO-1854 -merge from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7311481 ] Squashed commit of the following: commit dfbe098fb650d1d1605ac28ff0b195e229ecb345 Author: Josh Elser <elserj@apache.org> Date: Wed Nov 20 23:57:18 2013 -0500 ACCUMULO-1843 Add in log4j Level to RangeInputSplit. Add more tests, notably ones that exercise delegation of the input split to the Configuration. commit 38fdee9916edd938bea1642de5d4e5cf54a81596 Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 17:47:57 2013 -0500 ACCUMULO-1854 Fix up InputFormatBase to use the information stored on RangeInputSplit and fall back onto the Configuration. commit 0e6d1aba7eacef357e0a17c67a453dd5b50a49dc Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 16:23:49 2013 -0500 ACCUMULO-1854 Clean up constructors. Add a test. commit 2f59f81f6e75f8a90ccfe3df00c6ad3f69174e0c Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 15:46:39 2013 -0500 ACCUMULO-1854 Move RangeInputSplit into its own file and store all connection information into it.
          Hide
          ASF subversion and git services added a comment -

          Commit 3beb9f710f526672fc67850b84c4999d968dc925 in branch refs/heads/ACCUMULO-1854-merge from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=3beb9f7 ]

          ACCUMULO-1854 Remove unnecessary arguments from methods

          Show
          ASF subversion and git services added a comment - Commit 3beb9f710f526672fc67850b84c4999d968dc925 in branch refs/heads/ ACCUMULO-1854 -merge from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=3beb9f7 ] ACCUMULO-1854 Remove unnecessary arguments from methods
          Hide
          ASF subversion and git services added a comment -

          Commit 45ae55fcb74832983ffc188524790a56e5261ae0 in branch refs/heads/ACCUMULO-1854-merge from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=45ae55f ]

          Squashed commit of the following:

          commit dfbe098fb650d1d1605ac28ff0b195e229ecb345
          Author: Josh Elser <elserj@apache.org>
          Date: Wed Nov 20 23:57:18 2013 -0500

          ACCUMULO-1843 Add in log4j Level to RangeInputSplit. Add more tests, notably ones that exercise delegation of the input
          split to the Configuration.

          commit 38fdee9916edd938bea1642de5d4e5cf54a81596
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 17:47:57 2013 -0500

          ACCUMULO-1854 Fix up InputFormatBase to use the information stored on
          RangeInputSplit and fall back onto the Configuration.

          commit 0e6d1aba7eacef357e0a17c67a453dd5b50a49dc
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 16:23:49 2013 -0500

          ACCUMULO-1854 Clean up constructors. Add a test.

          commit 2f59f81f6e75f8a90ccfe3df00c6ad3f69174e0c
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 15:46:39 2013 -0500

          ACCUMULO-1854 Move RangeInputSplit into its own file and store all
          connection information into it.

          Show
          ASF subversion and git services added a comment - Commit 45ae55fcb74832983ffc188524790a56e5261ae0 in branch refs/heads/ ACCUMULO-1854 -merge from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=45ae55f ] Squashed commit of the following: commit dfbe098fb650d1d1605ac28ff0b195e229ecb345 Author: Josh Elser <elserj@apache.org> Date: Wed Nov 20 23:57:18 2013 -0500 ACCUMULO-1843 Add in log4j Level to RangeInputSplit. Add more tests, notably ones that exercise delegation of the input split to the Configuration. commit 38fdee9916edd938bea1642de5d4e5cf54a81596 Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 17:47:57 2013 -0500 ACCUMULO-1854 Fix up InputFormatBase to use the information stored on RangeInputSplit and fall back onto the Configuration. commit 0e6d1aba7eacef357e0a17c67a453dd5b50a49dc Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 16:23:49 2013 -0500 ACCUMULO-1854 Clean up constructors. Add a test. commit 2f59f81f6e75f8a90ccfe3df00c6ad3f69174e0c Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 15:46:39 2013 -0500 ACCUMULO-1854 Move RangeInputSplit into its own file and store all connection information into it.
          Hide
          ASF subversion and git services added a comment -

          Commit 45ae55fcb74832983ffc188524790a56e5261ae0 in branch refs/heads/ACCUMULO-1854-merge from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=45ae55f ]

          Squashed commit of the following:

          commit dfbe098fb650d1d1605ac28ff0b195e229ecb345
          Author: Josh Elser <elserj@apache.org>
          Date: Wed Nov 20 23:57:18 2013 -0500

          ACCUMULO-1843 Add in log4j Level to RangeInputSplit. Add more tests, notably ones that exercise delegation of the input
          split to the Configuration.

          commit 38fdee9916edd938bea1642de5d4e5cf54a81596
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 17:47:57 2013 -0500

          ACCUMULO-1854 Fix up InputFormatBase to use the information stored on
          RangeInputSplit and fall back onto the Configuration.

          commit 0e6d1aba7eacef357e0a17c67a453dd5b50a49dc
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 16:23:49 2013 -0500

          ACCUMULO-1854 Clean up constructors. Add a test.

          commit 2f59f81f6e75f8a90ccfe3df00c6ad3f69174e0c
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 15:46:39 2013 -0500

          ACCUMULO-1854 Move RangeInputSplit into its own file and store all
          connection information into it.

          Show
          ASF subversion and git services added a comment - Commit 45ae55fcb74832983ffc188524790a56e5261ae0 in branch refs/heads/ ACCUMULO-1854 -merge from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=45ae55f ] Squashed commit of the following: commit dfbe098fb650d1d1605ac28ff0b195e229ecb345 Author: Josh Elser <elserj@apache.org> Date: Wed Nov 20 23:57:18 2013 -0500 ACCUMULO-1843 Add in log4j Level to RangeInputSplit. Add more tests, notably ones that exercise delegation of the input split to the Configuration. commit 38fdee9916edd938bea1642de5d4e5cf54a81596 Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 17:47:57 2013 -0500 ACCUMULO-1854 Fix up InputFormatBase to use the information stored on RangeInputSplit and fall back onto the Configuration. commit 0e6d1aba7eacef357e0a17c67a453dd5b50a49dc Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 16:23:49 2013 -0500 ACCUMULO-1854 Clean up constructors. Add a test. commit 2f59f81f6e75f8a90ccfe3df00c6ad3f69174e0c Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 15:46:39 2013 -0500 ACCUMULO-1854 Move RangeInputSplit into its own file and store all connection information into it.
          Hide
          ASF subversion and git services added a comment -

          Commit 45ae55fcb74832983ffc188524790a56e5261ae0 in branch refs/heads/ACCUMULO-1854-merge from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=45ae55f ]

          Squashed commit of the following:

          commit dfbe098fb650d1d1605ac28ff0b195e229ecb345
          Author: Josh Elser <elserj@apache.org>
          Date: Wed Nov 20 23:57:18 2013 -0500

          ACCUMULO-1843 Add in log4j Level to RangeInputSplit. Add more tests, notably ones that exercise delegation of the input
          split to the Configuration.

          commit 38fdee9916edd938bea1642de5d4e5cf54a81596
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 17:47:57 2013 -0500

          ACCUMULO-1854 Fix up InputFormatBase to use the information stored on
          RangeInputSplit and fall back onto the Configuration.

          commit 0e6d1aba7eacef357e0a17c67a453dd5b50a49dc
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 16:23:49 2013 -0500

          ACCUMULO-1854 Clean up constructors. Add a test.

          commit 2f59f81f6e75f8a90ccfe3df00c6ad3f69174e0c
          Author: Josh Elser <elserj@apache.org>
          Date: Fri Nov 8 15:46:39 2013 -0500

          ACCUMULO-1854 Move RangeInputSplit into its own file and store all
          connection information into it.

          Show
          ASF subversion and git services added a comment - Commit 45ae55fcb74832983ffc188524790a56e5261ae0 in branch refs/heads/ ACCUMULO-1854 -merge from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=45ae55f ] Squashed commit of the following: commit dfbe098fb650d1d1605ac28ff0b195e229ecb345 Author: Josh Elser <elserj@apache.org> Date: Wed Nov 20 23:57:18 2013 -0500 ACCUMULO-1843 Add in log4j Level to RangeInputSplit. Add more tests, notably ones that exercise delegation of the input split to the Configuration. commit 38fdee9916edd938bea1642de5d4e5cf54a81596 Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 17:47:57 2013 -0500 ACCUMULO-1854 Fix up InputFormatBase to use the information stored on RangeInputSplit and fall back onto the Configuration. commit 0e6d1aba7eacef357e0a17c67a453dd5b50a49dc Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 16:23:49 2013 -0500 ACCUMULO-1854 Clean up constructors. Add a test. commit 2f59f81f6e75f8a90ccfe3df00c6ad3f69174e0c Author: Josh Elser <elserj@apache.org> Date: Fri Nov 8 15:46:39 2013 -0500 ACCUMULO-1854 Move RangeInputSplit into its own file and store all connection information into it.
          Show
          Josh Elser added a comment - Because RB is pretty broken as of late... https://git-wip-us.apache.org/repos/asf?p=accumulo.git;a=commitdiff;h=a9644f5b94d74466db624fb06bd3d70fb5bf9cf9;hp=6648056cac0a3d271744ab322e8fede221c1f792
          Hide
          ASF subversion and git services added a comment -

          Commit a9644f5b94d74466db624fb06bd3d70fb5bf9cf9 in branch refs/heads/ACCUMULO-1854-info-in-splits from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=a9644f5 ]

          ACCUMULO-1854 Fix up InputFormatBase to use the information stored on
          RangeInputSplit and fall back onto the Configuration.

          Show
          ASF subversion and git services added a comment - Commit a9644f5b94d74466db624fb06bd3d70fb5bf9cf9 in branch refs/heads/ ACCUMULO-1854 -info-in-splits from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=a9644f5 ] ACCUMULO-1854 Fix up InputFormatBase to use the information stored on RangeInputSplit and fall back onto the Configuration.
          Hide
          ASF subversion and git services added a comment -

          Commit 7c549ab0d5a05a1f5daa36be21ece2e9e291aa3c in branch refs/heads/ACCUMULO-1854-info-in-splits from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7c549ab ]

          ACCUMULO-1854 Clean up constructors. Add a test.

          Show
          ASF subversion and git services added a comment - Commit 7c549ab0d5a05a1f5daa36be21ece2e9e291aa3c in branch refs/heads/ ACCUMULO-1854 -info-in-splits from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7c549ab ] ACCUMULO-1854 Clean up constructors. Add a test.
          Hide
          ASF subversion and git services added a comment -

          Commit cdbed432400da7b17b177e4a53d9440ff23bff9f in branch refs/heads/ACCUMULO-1854-info-in-splits from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=cdbed43 ]

          ACCUMULO-1854 Move RangeInputSplit into its own file and store all
          connection information into it.

          Show
          ASF subversion and git services added a comment - Commit cdbed432400da7b17b177e4a53d9440ff23bff9f in branch refs/heads/ ACCUMULO-1854 -info-in-splits from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=cdbed43 ] ACCUMULO-1854 Move RangeInputSplit into its own file and store all connection information into it.
          Hide
          Josh Elser added a comment -

          First off, thanks to Christopher Tubbs and William Slacum because they were both helpful in talking this out.

          Came to the conclusion that I don't need to rework the Configuration object, but instead could leverage all of the necessary information inside of the RangeInputSplit class (instead of just the location and Range as it currently contains). This allows us to let multiple invocations of the AccumuloInputFormat create RangeInputSplits without requiring all of the connection information contained in the Configuration.

          This creates a much cleaner changeset as well as backwards compatibility with the current implementation which falls back to using the information in the Configuration when the information is not present (null) in the RangeInputSplit.

          Show
          Josh Elser added a comment - First off, thanks to Christopher Tubbs and William Slacum because they were both helpful in talking this out. Came to the conclusion that I don't need to rework the Configuration object, but instead could leverage all of the necessary information inside of the RangeInputSplit class (instead of just the location and Range as it currently contains). This allows us to let multiple invocations of the AccumuloInputFormat create RangeInputSplits without requiring all of the connection information contained in the Configuration. This creates a much cleaner changeset as well as backwards compatibility with the current implementation which falls back to using the information in the Configuration when the information is not present (null) in the RangeInputSplit.
          Hide
          Josh Elser added a comment -

          I was talking to Christopher tonight about this. He did bring up the good point about why not to use the AccumuloMultiTableInputFormat. One point we came to was that making these changes would allow single M/R jobs to talk to separate Accumulo clusters instead of a single cluster.

          I did settle on a change that I'm not completely happy about that is reliant on the fact that splits are generated by one host in serial. If they were generated in parallel, my approach would break. However, given that the InputFormata can't rely on getting the same Configuration object in each invocation of getSplits, the only other reliable approach I could come up with was to use something like HDFS which has its own sort of concurrency issues. Since it's not an issue now, I've punted on worrying about it.

          Show
          Josh Elser added a comment - I was talking to Christopher tonight about this. He did bring up the good point about why not to use the AccumuloMultiTableInputFormat. One point we came to was that making these changes would allow single M/R jobs to talk to separate Accumulo clusters instead of a single cluster. I did settle on a change that I'm not completely happy about that is reliant on the fact that splits are generated by one host in serial. If they were generated in parallel, my approach would break. However, given that the InputFormata can't rely on getting the same Configuration object in each invocation of getSplits, the only other reliable approach I could come up with was to use something like HDFS which has its own sort of concurrency issues. Since it's not an issue now, I've punted on worrying about it.
          Hide
          ASF subversion and git services added a comment -

          Commit c50a22296d80042a86639129a02e2b9468dc3330 in branch refs/heads/ACCUMULO-1854-multi-aif from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=c50a222 ]

          ACCUMULO-1854 Ended up re-implementing some of the old approach to get
          back to a functional state.

          Couldn't solely use the Configuration for things as getting the same
          Configuration each time getSplits is called isn't guaranteed. Since
          getSplits are always called serially by one client, we can use that fact
          to keep some state and not read the same data many times.

          Show
          ASF subversion and git services added a comment - Commit c50a22296d80042a86639129a02e2b9468dc3330 in branch refs/heads/ ACCUMULO-1854 -multi-aif from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=c50a222 ] ACCUMULO-1854 Ended up re-implementing some of the old approach to get back to a functional state. Couldn't solely use the Configuration for things as getting the same Configuration each time getSplits is called isn't guaranteed. Since getSplits are always called serially by one client, we can use that fact to keep some state and not read the same data many times.
          Hide
          ASF subversion and git services added a comment -

          Commit 0f10a6ffb0400424d30d3f49312bb500265cb276 in branch refs/heads/ACCUMULO-1854-multi-aif from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=0f10a6f ]

          ACCUMULO-1854 Lift duplicated code between AIF and AOF into a helper
          class

          Show
          ASF subversion and git services added a comment - Commit 0f10a6ffb0400424d30d3f49312bb500265cb276 in branch refs/heads/ ACCUMULO-1854 -multi-aif from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=0f10a6f ] ACCUMULO-1854 Lift duplicated code between AIF and AOF into a helper class
          Hide
          ASF subversion and git services added a comment -

          Commit 1fe223813a246a9943dbc9eda1a71de07ae27f12 in branch refs/heads/ACCUMULO-1854-multi-aif from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=1fe2238 ]

          ACCUMULO-1854 Make the same changes to AOF as AIF has.

          Show
          ASF subversion and git services added a comment - Commit 1fe223813a246a9943dbc9eda1a71de07ae27f12 in branch refs/heads/ ACCUMULO-1854 -multi-aif from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=1fe2238 ] ACCUMULO-1854 Make the same changes to AOF as AIF has.
          Hide
          ASF subversion and git services added a comment -

          Commit c5dc070f0c10c0f9b00647934edd35e22a6b036c in branch refs/heads/ACCUMULO-1854-multi-aif from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=c5dc070 ]

          ACCUMULO-1854 More unit tests and fix a bug.

          Show
          ASF subversion and git services added a comment - Commit c5dc070f0c10c0f9b00647934edd35e22a6b036c in branch refs/heads/ ACCUMULO-1854 -multi-aif from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=c5dc070 ] ACCUMULO-1854 More unit tests and fix a bug.
          Hide
          ASF subversion and git services added a comment -

          Commit 5d3c3d5fdd2691f87a5319672c1d9f7dd29f457f in branch refs/heads/ACCUMULO-1854-multi-aif from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=5d3c3d5 ]

          ACCUMULO-1854 Add AIF test to retrieve relevant configuration entries.
          Remove the internal AtomicIntegers in favor of state management through
          the Configuration object.

          Using static concurrent structures in the InputFormat didn't work well
          when making multiple calls to the class and altering the state. By
          holding state on the Configuration for the input format, we can
          alleviate some of this and do better duplication checking.

          Show
          ASF subversion and git services added a comment - Commit 5d3c3d5fdd2691f87a5319672c1d9f7dd29f457f in branch refs/heads/ ACCUMULO-1854 -multi-aif from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=5d3c3d5 ] ACCUMULO-1854 Add AIF test to retrieve relevant configuration entries. Remove the internal AtomicIntegers in favor of state management through the Configuration object. Using static concurrent structures in the InputFormat didn't work well when making multiple calls to the class and altering the state. By holding state on the Configuration for the input format, we can alleviate some of this and do better duplication checking.
          Hide
          Josh Elser added a comment -

          That's not a bad idea, but, if I understand you correctly, it wouldn't work for the case when you're not controlling the Job and Configuration yourself (e.g. Pig). At first glance, I wouldn't be able to use your approach because I'm handed a Job from the framework and have no ability to override a special Configuration object.

          But, when using MultipleInputs, your approach would definitely seem much more succinct.

          Show
          Josh Elser added a comment - That's not a bad idea, but, if I understand you correctly, it wouldn't work for the case when you're not controlling the Job and Configuration yourself (e.g. Pig). At first glance, I wouldn't be able to use your approach because I'm handed a Job from the framework and have no ability to override a special Configuration object. But, when using MultipleInputs, your approach would definitely seem much more succinct.
          Hide
          Bill Havanki added a comment -

          An alternative which would probably avoid a lot of the changes to AIF and AOF is to bake the sequencing idea into the Configuration object. I'm thinking a decorator around the Configuration which lets you shift it to the next sequence, say. It remembers where it is and the counts so far, and can enforce ordering access, bounds checking, maximums, etc.

          SequencedConfiguration sconf = new SequencedConfiguration(conf); // initially no sequence
          // do stuff with sconf
          sconf.increment()
          // next pass with sequence 1
          ...

          Show
          Bill Havanki added a comment - An alternative which would probably avoid a lot of the changes to AIF and AOF is to bake the sequencing idea into the Configuration object. I'm thinking a decorator around the Configuration which lets you shift it to the next sequence, say. It remembers where it is and the counts so far, and can enforce ordering access, bounds checking, maximums, etc. SequencedConfiguration sconf = new SequencedConfiguration(conf); // initially no sequence // do stuff with sconf sconf.increment() // next pass with sequence 1 ...
          Hide
          Josh Elser added a comment -

          Review is welcome/appreciated if anyone has opinions on this. The changes should be backwards compatible. It's fixed the use case I had which was to make the MultipleInput-esque code that Pig has work with Accumulo.

          Show
          Josh Elser added a comment - Review is welcome/appreciated if anyone has opinions on this. The changes should be backwards compatible. It's fixed the use case I had which was to make the MultipleInput-esque code that Pig has work with Accumulo.
          Hide
          ASF subversion and git services added a comment -

          Commit 921617d4dac38e81571dc852308ff4924530092b in branch refs/heads/ACCUMULO-1854-multi-aif from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=921617d ]

          ACCUMULO-1854 First stab at being able to use multiple
          AccumuloInputFormats and AccumuloOutputFormats in the same
          Configuration.

          Modified the static API calls on both AIF and AOF to include the notion
          of a "sequence" number. The original methods still exist, defaulting to
          '0', to preserve backwards compatibility with API and functionality. A
          primitive method to get a sequence number was added to both and is used
          to properly generate InputSplits and output info.

          Show
          ASF subversion and git services added a comment - Commit 921617d4dac38e81571dc852308ff4924530092b in branch refs/heads/ ACCUMULO-1854 -multi-aif from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=921617d ] ACCUMULO-1854 First stab at being able to use multiple AccumuloInputFormats and AccumuloOutputFormats in the same Configuration. Modified the static API calls on both AIF and AOF to include the notion of a "sequence" number. The original methods still exist, defaulting to '0', to preserve backwards compatibility with API and functionality. A primitive method to get a sequence number was added to both and is used to properly generate InputSplits and output info.
          Hide
          Josh Elser added a comment -

          My initial approach is to introduce the notion of a "sequence id" to the Input/Output Formats. Adding new methods to each class allows us to preserve the old functionality (of one "configuration" per Configuration), yet also gives clients the hooks to store multiple configurations.

          My only concern was the contract on the getSplits() method. I believe we can increment through each sequence id that we "gave" clients and attempt to set each of them. Initial tests seem to show that this approach will work out.

          Show
          Josh Elser added a comment - My initial approach is to introduce the notion of a "sequence id" to the Input/Output Formats. Adding new methods to each class allows us to preserve the old functionality (of one "configuration" per Configuration), yet also gives clients the hooks to store multiple configurations. My only concern was the contract on the getSplits() method. I believe we can increment through each sequence id that we "gave" clients and attempt to set each of them. Initial tests seem to show that this approach will work out.

            People

            • Assignee:
              Josh Elser
              Reporter:
              Josh Elser
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development