Accumulo
  1. Accumulo
  2. ACCUMULO-178

Off-by-one error in FamilyIntersectingIterator

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.3.5
    • Fix Version/s: 1.3.6, 1.4.0
    • Component/s: tserver
    • Labels:

      Description

      In the buildDocKey() function within the FamilyIntersectingIterator there is a bug that shortens the docID by 1. This causes the wrong doc's data to be returned in the results of a query using this Iterator.

      1. family-iterator.patch
        0.8 kB
        Jason Trost
      2. family-iterator-with-tests.patch
        3 kB
        Jason Trost

        Activity

        Jason Trost created issue -
        Hide
        Jason Trost added a comment -

        see attached patch.

        Show
        Jason Trost added a comment - see attached patch.
        Jason Trost made changes -
        Field Original Value New Value
        Attachment family-iterator.patch [ 12504904 ]
        Jason Trost made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Eric Newton added a comment -

        Thanks Jason! Could I trouble you to add to the FamilyIntersectingIteratorTest so that the bug is demonstrated/detected?

        Show
        Eric Newton added a comment - Thanks Jason! Could I trouble you to add to the FamilyIntersectingIteratorTest so that the bug is demonstrated/detected?
        Hide
        Jason Trost added a comment -

        See attached patch. These test cases now look for the correct value associated with the docID.

        Show
        Jason Trost added a comment - See attached patch. These test cases now look for the correct value associated with the docID.
        Jason Trost made changes -
        Attachment family-iterator-with-tests.patch [ 12504976 ]
        Billie Rinaldi made changes -
        Assignee Keith Turner [ kturner ] Jason Trost [ jasontrost ]
        Eric Newton made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Keith Turner made changes -
        Fix Version/s 1.4.0 [ 12318441 ]
        Fix Version/s 1.3.6 [ 12319045 ]
        Fix Version/s 1.5.0 [ 12318645 ]
        Affects Version/s 1.4.0 [ 12318441 ]
        Affects Version/s 1.5.0 [ 12318645 ]
        Affects Version/s 1.3.6 [ 12319045 ]
        Gavin made changes -
        Workflow no-reopen-closed, patch-avail [ 12643226 ] patch-available, re-open possible [ 12671609 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        8m 7s 1 Jason Trost 23/Nov/11 18:29
        Patch Available Patch Available Resolved Resolved
        21h 1 Eric Newton 24/Nov/11 15:30

          People

          • Assignee:
            Jason Trost
            Reporter:
            Jason Trost
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1m
              1m
              Remaining:
              Remaining Estimate - 1m
              1m
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development