[ACCUMULO-1242] Consistent logging

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Component/s: build
• Labels: log4j logging logs slf4j
• Assignee: Ed Coleman
• Reporter: Christopher Tubbs
• Created: 04/Apr/13 22:04
• Updated: 11/Jun/19 04:23
• Resolved: 11/Jun/19 04:23

Description

Logging dependencies are very inconsistent. It seems we have absolute dependencies on log4j, yet use slf4j sometimes, and log4j other times. In some of our tests we have slf4j-nop as a test dependency.

It seems we could consolidate a lot of this if we simply did:

1. slf4j-api : compile
2. slf4j-log4j12 : runtime
3. slf4j-nop : test
4. log4j : runtime

We could do this in the parent POM and get rid of all the different dependencies throughout the code.

I don't know that we could ever use anything other than slf4j-log4j12 as the implementation (unless our dependencies broke away from using log4j directly also), but at least we'd clean up all the logging dependencies in our code/build, and would be ready to switch to something better if something came along. Further, if somebody wanted to reuse our code, and weren't tied to log4j, because they didn't need our transitive dependencies that locked in log4j, they could easily depend on their own slf4j implementation jar, and all the logging in our code would still work correctly for them without needing to use something like log4j-over-slf4j.

Issue Links

• is related to: ACCUMULO-2304 Change Log Levels to not necessitate running DEBUG in production
• is related to: ACCUMULO-3162 make log members (to the extent possible) private static final
• relates to: ACCUMULO-3329 Consider consolidation of "timing" classes
• requires: ACCUMULO-1879 Separate shell into its own module
• requires: ACCUMULO-1880 Separate mapreduce into its own module

Sub-Tasks

• Add checkstyle rule to ban log4j imports: Resolved
• Mark slf4j implementation dependencies "optional": Resolved
• Replace log4j dependencies with slf4j where setLevel is not used.: Resolved
• Remove string concatenation in log statements where slf4j is used.: Resolved
• Replace TLevel: Resolved
• Remove / deprecate use of log4j setLevel to dynamically control logging: Resolved
• TableConfWatcher (And TableNamespaceConfWatcher) shouldn't override logging: Resolved
• Avoid string format injection problems: Resolved
• Add slf4j to Main classpath: Resolved
• Refactor OpTimer so that it does not use log4j logger.: Resolved