Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.4.0
    • Labels:
      None

      Description

      I'm creating this issue to capture patches/ideas that I and others may have along these lines

      1. collectionProvider.patch
        71 kB
        Dan Diephouse
      2. contentProvider.patch
        39 kB
        Dan Diephouse

        Activity

        Hide
        James M Snell added a comment -

        Things are much better now

        Show
        James M Snell added a comment - Things are much better now
        Hide
        Davanum Srinivas added a comment -

        James,

        I ran APE against latest svn with collectionProvider.patch. Looks good. Look for "!" in the text below for the error (29 and 31).

        thanks,
        dims

        Summary: 2 errors, 7 warnings.

        1.

        TESTING: Service document and collections.
        2.

        ✓ Retrieval of Service Document: it exists and is served properly. [Dialog]
        3.

        Found these collections:
        *

        'Simple' accepts application/atom+xml;type=entry
        4.

        Will use collection 'Simple' for entry creation.
        5.

        ✓ Page 1 of Entry collection: it exists and is served properly. [Dialog]
        6.

        Page 1 of Entry collection has no entries.
        7.

        ✓ Entry collection has correct app:edited value order.
        8.

        TESTING: Entry-posting basics.
        9.

        ✓ Posting of new entry to the Entries collection reported success, Location: http://www-us.wso2.com:8088/abdera-webapp/atom/feed/urn:uuid:BA8BB22FB8B079ACA91190665879709 [Dialog]
        10.

        Examining the new entry as returned in the POST response
        11.

        ✓ Returned entry is consistent with posted entry.
        12.

        ✓ Provided categories included in Returned entry.
        13.

        ✓ Server preserved foreign markup in Returned entry.
        14.

        ✓ Retrieval of newly created entry: it exists and is served properly. [Dialog]
        15.

        Examining the new entry as retrieved using Location header in POST response:
        16.

        ? Client-provided slug 'ape-24210' not used in server-generated URI.
        17.

        ✓ Retrieved entry is consistent with posted entry.
        18.

        ✓ Provided categories included in Retrieved entry.
        19.

        ✓ Server preserved foreign markup in Retrieved entry.
        20.

        Examining the new entry as it appears in the collection feed:
        21.

        ✓ Entry from collection feed is consistent with posted entry.
        22.

        ✓ Provided categories included in Entry from collection feed.
        23.

        ✓ Server preserved foreign markup in Entry from collection feed.
        24.

        ? Can't update new entry with PUT: Not Found [Dialog]
        25.

        ✓ Entry deletion reported success. [Dialog]
        26.

        ✓ Entry not found in feed after deletion.
        27.

        TESTING: Collection re-ordering after PUT.
        28.

        ✓ Page 1 of Entries with multi-post: it exists and is served properly. [Dialog]
        29.

        ! 3 of 3 entries in Entries with multi-post lack app:edited elements.
        30.

        ✓ Entries correctly ordered after multi-post.
        31.

        ! Can't update mini-entry at http://www-us.wso2.com:8088/abdera-webapp/atom/feed/urn:uuid:BA8BB22FB8B079ACA91190665884793 [Dialog]
        32.

        TESTING: Content sanitization
        33.

        ✓ Retrieval of unclean XHTML entry: it exists and is served properly. [Dialog]
        34.

        ? Published entry retains xhtml:script element.
        35.

        ? Published entry retains 'background' attribute.
        36.

        ? Published entry retains 'style' attribute.
        37.

        ? Published entry retains dangerous hyperlink: 'javascript:evil'.
        38.

        ? No collection for 'image/jpeg', won't test media posting.

        Show
        Davanum Srinivas added a comment - James, I ran APE against latest svn with collectionProvider.patch. Looks good. Look for "!" in the text below for the error (29 and 31). thanks, dims Summary: 2 errors, 7 warnings. 1. TESTING: Service document and collections. 2. ✓ Retrieval of Service Document: it exists and is served properly. [Dialog] 3. Found these collections: * 'Simple' accepts application/atom+xml;type=entry 4. Will use collection 'Simple' for entry creation. 5. ✓ Page 1 of Entry collection: it exists and is served properly. [Dialog] 6. Page 1 of Entry collection has no entries. 7. ✓ Entry collection has correct app:edited value order. 8. TESTING: Entry-posting basics. 9. ✓ Posting of new entry to the Entries collection reported success, Location: http://www-us.wso2.com:8088/abdera-webapp/atom/feed/urn:uuid:BA8BB22FB8B079ACA91190665879709 [Dialog] 10. Examining the new entry as returned in the POST response 11. ✓ Returned entry is consistent with posted entry. 12. ✓ Provided categories included in Returned entry. 13. ✓ Server preserved foreign markup in Returned entry. 14. ✓ Retrieval of newly created entry: it exists and is served properly. [Dialog] 15. Examining the new entry as retrieved using Location header in POST response: 16. ? Client-provided slug 'ape-24210' not used in server-generated URI. 17. ✓ Retrieved entry is consistent with posted entry. 18. ✓ Provided categories included in Retrieved entry. 19. ✓ Server preserved foreign markup in Retrieved entry. 20. Examining the new entry as it appears in the collection feed: 21. ✓ Entry from collection feed is consistent with posted entry. 22. ✓ Provided categories included in Entry from collection feed. 23. ✓ Server preserved foreign markup in Entry from collection feed. 24. ? Can't update new entry with PUT: Not Found [Dialog] 25. ✓ Entry deletion reported success. [Dialog] 26. ✓ Entry not found in feed after deletion. 27. TESTING: Collection re-ordering after PUT. 28. ✓ Page 1 of Entries with multi-post: it exists and is served properly. [Dialog] 29. ! 3 of 3 entries in Entries with multi-post lack app:edited elements. 30. ✓ Entries correctly ordered after multi-post. 31. ! Can't update mini-entry at http://www-us.wso2.com:8088/abdera-webapp/atom/feed/urn:uuid:BA8BB22FB8B079ACA91190665884793 [Dialog] 32. TESTING: Content sanitization 33. ✓ Retrieval of unclean XHTML entry: it exists and is served properly. [Dialog] 34. ? Published entry retains xhtml:script element. 35. ? Published entry retains 'background' attribute. 36. ? Published entry retains 'style' attribute. 37. ? Published entry retains dangerous hyperlink: 'javascript:evil'. 38. ? No collection for 'image/jpeg', won't test media posting.
        Hide
        Dan Diephouse added a comment -

        Here's an updated and improved version of my attempt to simplify things. This is what happens when I spend all day in airports & planes

        There are a couple changes:
        1. The list of workspaces and collections can now be provided dynamically
        2. Removal of the ContentInfo class which was useless
        3. Create a CollectionProvider which is similar to Provider, but provides collection specific info only. The WorkspaceProvider is simply in charge of finding the right CollectionProvider to use and invoking it..
        4. Move the methods which make it easy to map a business entity to an entry to the AbstractCollectionProvider class.

        Show
        Dan Diephouse added a comment - Here's an updated and improved version of my attempt to simplify things. This is what happens when I spend all day in airports & planes There are a couple changes: 1. The list of workspaces and collections can now be provided dynamically 2. Removal of the ContentInfo class which was useless 3. Create a CollectionProvider which is similar to Provider, but provides collection specific info only. The WorkspaceProvider is simply in charge of finding the right CollectionProvider to use and invoking it.. 4. Move the methods which make it easy to map a business entity to an entry to the AbstractCollectionProvider class.

          People

          • Assignee:
            Unassigned
            Reporter:
            Dan Diephouse
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development