It would be interesting to refactor slightly HTTPHC4Impl to allow inheriting classes to reuse many of already implemented and useful internals. This would be useful to classes that wish for example to post binary content and similar stuff.
Created attachment 30523 [details] Proposed patch
There seem to be some spurious changes in the patch in the setupRequest method; it's difficult to work out what is actually changing. Also there needs to be better Javadoc for the protected methods, especially if they are intended for use by 3rd party addins. If only intended for use by JMeter, then that also needs to be documented.
Created attachment 30552 [details] Updated patch as per sebb notes
Date: Mon Jul 8 20:11:00 2013 New Revision: 1500926 URL: http://svn.apache.org/r1500926 Log: Bug 55175 - HTTPHC4Impl refactoring to allow better inheritance Bugzilla Id: 55175 Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java jmeter/trunk/xdocs/changes.xml
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/3153