Bug 55175 - HTTPHC4Impl refactoring to allow better inheritance
HTTPHC4Impl refactoring to allow better inheritance
Status: RESOLVED FIXED
Product: JMeter
Classification: Unclassified
Component: HTTP
Nightly (Please specify date)
All All
: P2 enhancement (vote)
: ---
Assigned To: JMeter issues mailing list
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2013-07-01 15:18 UTC by Philippe Mouawad
Modified: 2013-07-26 20:15 UTC (History)
1 user (show)



Attachments
Proposed patch (8.12 KB, patch)
2013-07-02 10:34 UTC, Philippe Mouawad
Details | Diff
Updated patch as per sebb notes (6.21 KB, patch)
2013-07-06 20:39 UTC, Philippe Mouawad
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Mouawad 2013-07-01 15:18:35 UTC
It would be interesting to refactor slightly HTTPHC4Impl to allow inheriting classes to reuse many of already implemented and useful internals.
This would be useful to classes that wish for example to post binary content and similar stuff.
Comment 1 Philippe Mouawad 2013-07-02 10:34:20 UTC
Created attachment 30523 [details]
Proposed patch
Comment 2 Sebb 2013-07-04 12:59:55 UTC
There seem to be some spurious changes in the patch in the setupRequest method; it's difficult to work out what is actually changing.

Also there needs to be better Javadoc for the protected methods, especially if they are intended for use by 3rd party addins. If only intended for use by JMeter, then that also needs to be documented.
Comment 3 Philippe Mouawad 2013-07-06 20:39:29 UTC
Created attachment 30552 [details]
Updated patch as per sebb notes
Comment 4 Philippe Mouawad 2013-07-08 20:11:41 UTC
Date: Mon Jul  8 20:11:00 2013
New Revision: 1500926

URL: http://svn.apache.org/r1500926
Log:
Bug 55175 - HTTPHC4Impl refactoring to allow better inheritance
Bugzilla Id: 55175

Modified:
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java
    jmeter/trunk/xdocs/changes.xml