I have been trying to gain a more in depth knowledge of the Apache httpd and APR source. In the process of studying through the APR headers, I noticed several comment errors. So I will submit a patch containing 52 corrections within a total of 14 of the APR header files. These are a mix of comment typos and places where the comments and code do not match. I limited this patch to comment changes only. In the case of the mismatches, it might be preferred to change the code in some cases, such as the changes for apr_escape.h. But I also noticed the following code blemishes: The file apr_global_mutex.h includes apr_proc_mutex.h twice: #include "apr.h" #include "apr_proc_mutex.h" /* only for apr_lockmech_e */ #include "apr_pools.h" #include "apr_errno.h" #if APR_PROC_MUTEX_IS_GLOBAL #include "apr_proc_mutex.h" #endif And the file apr_thread_proc.h defines APR_NO_FILE twice. I hope that this set of changes will help to improve the generated documentation for APR and APR-util. Thanks, Mike
Created attachment 30481 [details] A collection of comment corrections to the APR header files
Committed to apr trunk as r1496407. If you'll split this up by apr-1.5.x/apr-util-1.5.x I'll commit there as well.
Created attachment 30486 [details] Comment changes for apr-1.5.x header files
Created attachment 30487 [details] Comment changes for apr-util-1.5.x header files
Created attachment 30488 [details] A slight correction to apr-util-1.5.x_comment changes.