Bug 51328 - StringManager/ResourceBundle parsing error causes webapp deployment to fail on ppc64 gcj
Summary: StringManager/ResourceBundle parsing error causes webapp deployment to fail o...
Status: RESOLVED INVALID
Alias: None
Product: Tomcat 6
Classification: Unclassified
Component: Catalina (show other bugs)
Version: 6.0.32
Hardware: All other
: P2 normal (vote)
Target Milestone: default
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-06 19:11 UTC by dknox
Modified: 2011-06-20 13:16 UTC (History)
0 users



Attachments
Patch for StringManager (969 bytes, patch)
2011-06-06 19:11 UTC, dknox
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dknox 2011-06-06 19:11:34 UTC
Created attachment 27119 [details]
Patch for StringManager

On some jvms (IBM and GCJ/ jdk1.5 on ppc64, org/apache/catalina/util/StringManager initialization can fail due to a runtime exception when a localstring can't be parsed (e.g, NumberFormatException). The failure can occur during context and session initialization and cause a complete failure to deploy a webapp. A patch is attached.
Comment 1 Konstantin Kolinko 2011-06-06 21:01:15 UTC
What exactly error and stacktrace you are observing?

I do not quite get it where invalid values can come from. It it a real use case? Why there is no MissingResourceException?


There is try/catch in the StringManager constructor already. Any additional error handling may go there.


BTW,
1) The proposed patch is wrong (it does not update managers hashtable, it catches too much - it should not catch Errors) and it does not respect code formatting.
2) GCJ has known issues and is certainly not recommended for production environments, as was mentioned several times on the users@ list.
Comment 2 Mark Thomas 2011-06-20 13:16:56 UTC
No response to Konstantin's questions and since gcj is known to have all sorts of issues, resolving this as invalid since it appears to be (another) gcj issue.