Bug 50088 - getAvgPageBytes in SamplingStatCalculator does not what it says
getAvgPageBytes in SamplingStatCalculator does not what it says
Status: RESOLVED FIXED
Product: JMeter
Classification: Unclassified
Component: Main
2.4
PC Windows XP
: P2 enhancement (vote)
: ---
Assigned To: JMeter issues mailing list
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2010-10-13 11:13 UTC by jens_0
Modified: 2010-10-21 09:26 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jens_0 2010-10-13 11:13:02 UTC
getAvgPageBytes in StatCalculator is correct, but in SamplingStatCalculator, it divides through the duration of the sample (and not, as the comment is saying, divided by the number ob samples), resulting in about the same value than geKBPerSecond.

Change this.getElapsed() / 1000 to this.getCount().
Comment 1 Sebb 2010-10-21 09:26:03 UTC
Oops! Well spotted. 

Originally there was a method called getPageSize()
This is now renamed as getBytesPerSecond() (because that is what it did).

The intention was to add getAvgPageBytes() to return what the Javadoc says, but it seems the code copied from getPageSize() code was not amended.

URL: http://svn.apache.org/viewvc?rev=1025989&view=rev
Log:
Bug 50088 - fix getAvgPageBytes in SamplingStatCalculator so it returns what it should

Modified:
   jakarta/jmeter/trunk/src/core/org/apache/jmeter/visualizers/SamplingStatCalculator.java
   jakarta/jmeter/trunk/xdocs/changes.xml