Bug 48908 - Select instructions should implement StackConsumer instead of StackProducer
Summary: Select instructions should implement StackConsumer instead of StackProducer
Status: RESOLVED FIXED
Alias: None
Product: BCEL - Now in Jira
Classification: Unclassified
Component: Main (show other bugs)
Version: 5.2
Hardware: PC Windows Vista
: P2 minor
Target Milestone: ---
Assignee: issues@commons.apache.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-14 12:52 UTC by hobbbo
Modified: 2011-03-13 14:41 UTC (History)
1 user (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description hobbbo 2010-03-14 12:52:24 UTC 
Select instruction (class org.apache.bcel.generic.Select) is currently implementing interface StackProducer. It should instead, implement interface StackConsumer, since both instructions LOOKUPSWITCH and TABLESWITCH do consume (pop) the operand stack. In addition calls to produceStack() and consumeStack() do return the correct value.
Comment 1 Dave Brosius 2011-03-13 14:41:46 UTC 
Thanks for the report, 
Committed revision 1081190.