Bug 41794 - Maven POM file calls in apache regex but code does not use it
Summary: Maven POM file calls in apache regex but code does not use it
Status: RESOLVED FIXED
Alias: None
Product: BCEL - Now in Jira
Classification: Unclassified
Component: Main (show other bugs)
Version: unspecified
Hardware: Other other
: P2 normal
Target Milestone: ---
Assignee: issues@commons.apache.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-08 14:55 UTC by Ian Darwin
Modified: 2007-03-10 06:48 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Darwin 2007-03-08 14:55:46 UTC
Seems the code was modernized to use java.util.regex but the Maven POM file was
not updated at the time.

A simple SVN patch is here:

Index: /home/ian/workspace/bcel/pom.xml
===================================================================
--- /home/ian/workspace/bcel/pom.xml	(revision 516101)
+++ /home/ian/workspace/bcel/pom.xml	(working copy)
@@ -170,11 +170,6 @@
 
 	<dependencies>
 		<dependency>
-			<groupId>jakarta-regexp</groupId>
-			<artifactId>jakarta-regexp</artifactId>
-			<version>1.4</version>
-		</dependency>
-		<dependency>
 			<groupId>junit</groupId>
 			<artifactId>junit</artifactId>
 			<version>3.8.1</version>

Given that the only external dependency is now junit3.8 which *everybody* has a
copy of, one could switch from Maven to Ant and avoid the dependency on Maven,
but that's rather a different story :-)
Comment 1 Ian Darwin 2007-03-08 15:09:07 UTC
Err, whomever commits that should also commit this repair of the
relevant comment in o.a.b.util.InstructionFinder:

Index:
/home/ian/workspace/bcel/src/main/java/org/apache/bcel/util/InstructionFinder.java
===================================================================
---
/home/ian/workspace/bcel/src/main/java/org/apache/bcel/util/InstructionFinder.java
(revision 516101)
+++
/home/ian/workspace/bcel/src/main/java/org/apache/bcel/util/InstructionFinder.java
(working copy)
@@ -1,7 +1,7 @@
 /*
  * Copyright  2000-2004 The Apache Software Foundation
  *
- *  Licensed under the Apache License, Version 2.0 (the "License"); 
+ *  Licensed under the Apache License, Version 2.0 (the "License");
  *  you may not use this file except in compliance with the License.
  *  You may obtain a copy of the License at
  *
@@ -11,7 +11,7 @@
  *  distributed under the License is distributed on an "AS IS" BASIS,
  *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  *  See the License for the specific language governing permissions and
- *  limitations under the License. 
+ *  limitations under the License.
  *
  */
 package org.apache.bcel.util;
@@ -36,19 +36,19 @@
  * expressions. This can be used, e.g., in order to implement a peep hole
  * optimizer that looks for code patterns and replaces them with faster
  * equivalents.
- * 
+ *
  * <p>
- * This class internally uses the <a href="http://jakarta.apache.org/regexp/">
- * Regexp</a> package to search for regular expressions.
- * 
+ * This class internally uses the java.util.regex
+ * package to search for regular expressions.
+ *
  * A typical application would look like this:
- * 
+ *
  * <pre>
- * 
- *  
+ *
+ *
  *   InstructionFinder f   = new InstructionFinder(il);
  *   String            pat = &quot;IfInstruction ICONST_0 GOTO ICONST_1 NOP
(IFEQ|IFNE)&quot;;
- *   
+ *
  *   for(Iterator i = f.search(pat, constraint); i.hasNext(); ) {
  *   InstructionHandle[] match = (InstructionHandle[])i.next();
  *   ...
Comment 2 Torsten Curdt 2007-03-10 06:48:17 UTC
Thanks, applied. Please next time attach the patches.