Summary: | StatCalculator.addAll(StatCalculator<T> calc) joins incorrect if there are more samples with the same response time in one of the TreeMap | ||
---|---|---|---|
Product: | JMeter - Now in Github | Reporter: | alena <briskarova> |
Component: | Main | Assignee: | JMeter issues mailing list <issues> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | briskarova |
Priority: | P2 | ||
Version: | 2.3.4 | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All | ||
Bug Depends on: | |||
Bug Blocks: | 52339 |
Description
alena
2011-11-02 15:51:37 UTC
Thanks! Good examples and fix. Ideally patches should be provided as unified diffs as these are easier to review and apply, but in this case it was easy to see the changes. Applied with one minor change: used entrySet for the iterator as now need the value as well as the key. URL: http://svn.apache.org/viewvc?rev=1197376&view=rev Log: Bug 52125 - StatCalculator.addAll(StatCalculator calc) joins incorrect if there are more samples with the same response time in one of the TreeMap Modified: jmeter/trunk/src/jorphan/org/apache/jorphan/math/StatCalculator.java jmeter/trunk/test/src/org/apache/jorphan/math/TestStatCalculator.java jmeter/trunk/xdocs/changes.xml The fix broke processing of StatisticalSampleResults. The problem is that the StatisticalSampleResults class accumulates the elapsed time for each sample, whereas the StatCalculator classes count samples with the same values. In the first case, there is no need to multiply by the number of samples, but in the second the value needs to be adjusted before use. Also need to add some tests for the StatisticalSampleResults class. URL: http://svn.apache.org/viewvc?rev=1221486&view=rev Log: Bug 52339 - JMeter Statistical mode in distributed testing shows wrong response time< Modified: jmeter/trunk/src/jorphan/org/apache/jorphan/math/StatCalculator.java jmeter/trunk/src/jorphan/org/apache/jorphan/math/StatCalculatorInteger.java jmeter/trunk/src/jorphan/org/apache/jorphan/math/StatCalculatorLong.java jmeter/trunk/test/src/org/apache/jorphan/math/TestStatCalculator.java jmeter/trunk/xdocs/changes.xml This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/2632 |